Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp987958ybk; Sun, 10 May 2020 02:54:10 -0700 (PDT) X-Google-Smtp-Source: APiQypJdg6gNTWaYVnKIuf+agoO2XNA25Twxj6jMwb62zNBi5ZE4si1aVHEZ0SK51hUpxwcu9Bw6 X-Received: by 2002:aa7:d78a:: with SMTP id s10mr9274422edq.319.1589104450041; Sun, 10 May 2020 02:54:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589104450; cv=none; d=google.com; s=arc-20160816; b=re/4wE45UEtaSsf90gmKv+jgswoFcDK3PguN3623eVsnzMKilIAkrSgM9dDN0ysfY+ 0O9fzbWKmnQX4aE7JGVxUwZSQlFbEYRWNcWCdBX1W6i5Koi9cgul2uww1RNcRW6iUiBS T5QnF8L8XET+7F8FAEujJiXfGmHlKvAhF3Izn8v+Cbd1ooZfWlKsyVaRr7dR/yBPNS9N XHU1CUgUc8t5tmdwTaNq4B1G2t475FqmQudCUh1HxuUK2BU7g+yr/W4lJMR9T0Fp0ajp fwh7//LmUCHq9PtrdqCE5ieULDrBAJ9FGUJ7VHWl0zYmxHbOT/yXmngq098ygVJ4bTLS AXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cNtYXjixF0fqRaET3adkO4MDXUk0QlYozthL5UF0nwQ=; b=TlkJX/YsUl/3ybjNcyIo5gxFfhQw74iubYz2Oi+inDW520tjxcipOHAGiCtq6W5jvZ BZfts4FNWvTrksiouGLUwtMpUdz4EymHj+hhSfsUIy70HqNjChXBOPka+R9twg1SKJXQ lGLjJeallXLTDQNb+FsGEoq/9LBMbQV/SVTasXE2coGaB2TV46hFDiDl2PuKsOfRitoF b612XcHSAVB7rNAbI5PFnX9l3atGBr1pJDu2OBdqBwCKN/OGLTGkU89iC2VS6t6tnHTj shcr9tCtuOueRU1PDUza/pJ6IZ7TsHEXs1sCAn1coC800mPQCWwhp3m8NfFzmwAITv4u Oayg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t24si3949046ejb.144.2020.05.10.02.53.47; Sun, 10 May 2020 02:54:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729090AbgEJJvL (ORCPT + 99 others); Sun, 10 May 2020 05:51:11 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:46160 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729066AbgEJJvJ (ORCPT ); Sun, 10 May 2020 05:51:09 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 362448000B81; Sun, 10 May 2020 09:51:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RTYjy1LzhIKT; Sun, 10 May 2020 12:51:05 +0300 (MSK) From: Serge Semin To: Jarkko Nikula , Andy Shevchenko , Mika Westerberg CC: Serge Semin , Serge Semin , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Rob Herring , Frank Rowand , , , Wolfram Sang , Jean Delvare , Felipe Balbi , Chuhong Yuan , "Rafael J. Wysocki" , Hanjun Guo , Hans de Goede , , Subject: [PATCH v2 10/12] i2c: designware: Discard Cherry Trail model flag Date: Sun, 10 May 2020 12:50:16 +0300 Message-ID: <20200510095019.20981-11-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20200510095019.20981-1-Sergey.Semin@baikalelectronics.ru> References: <20200306132001.1B875803087C@mail.baikalelectronics.ru> <20200510095019.20981-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C bus pm_disabled workaround"), but the flag most likely by mistake has been left in the Dw I2C drivers. Lets remove it. By doing so we get rid from the last DW APB I2C IP-core model flag, so we can remove the MODEL_MASK macro too. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Paul Burton Cc: Ralf Baechle Cc: Rob Herring Cc: Frank Rowand Cc: linux-mips@vger.kernel.org Cc: devicetree@vger.kernel.org --- drivers/i2c/busses/i2c-designware-core.h | 3 --- drivers/i2c/busses/i2c-designware-pcidrv.c | 1 - drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index 64544777a1fa..5a1f6b623a9a 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -281,9 +281,6 @@ struct dw_i2c_dev { #define ACCESS_INTR_MASK 0x00000004 #define ACCESS_NO_IRQ_SUSPEND 0x00000008 -#define MODEL_CHERRYTRAIL 0x00000100 -#define MODEL_MASK 0x00000f00 - int i2c_dw_init_regmap(struct dw_i2c_dev *dev); u32 i2c_dw_scl_hcnt(u32 ic_clk, u32 tSYMBOL, u32 tf, int cond, int offset); u32 i2c_dw_scl_lcnt(u32 ic_clk, u32 tLOW, u32 tf, int offset); diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index 7a0b65b5b5b5..76357b575aa5 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -166,7 +166,6 @@ static struct dw_pci_controller dw_pci_controllers[] = { .tx_fifo_depth = 32, .rx_fifo_depth = 32, .functionality = I2C_FUNC_10BIT_ADDR, - .flags = MODEL_CHERRYTRAIL, .scl_sda_cfg = &byt_config, }, [elkhartlake] = { diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 1f56865bb6ca..f577e2a92a4f 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -124,7 +124,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = { { "INT3432", 0 }, { "INT3433", 0 }, { "80860F41", ACCESS_NO_IRQ_SUSPEND }, - { "808622C1", ACCESS_NO_IRQ_SUSPEND | MODEL_CHERRYTRAIL }, + { "808622C1", ACCESS_NO_IRQ_SUSPEND }, { "AMD0010", ACCESS_INTR_MASK }, { "AMDI0010", ACCESS_INTR_MASK }, { "AMDI0510", 0 }, -- 2.25.1