Subject: Re: [PATCH] KERN_SETUID_DUMPABLE in /proc/sys/fs/
From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Kurt Garloff <garloff@suse.de>, linux-kernel@vger.kernel.org,
       torvalds@osdl.org
In-Reply-To: <20060310145605.08bf2a67.akpm@osdl.org>
References: <20060310155738.GL5766@tpkurt.garloff.de>
	 <20060310145605.08bf2a67.akpm@osdl.org>
Content-Type: text/plain
Date: Sat, 11 Mar 2006 08:23:36 +0100
Message-Id: <1142061816.3055.6.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 894
Lines: 23

On Fri, 2006-03-10 at 14:56 -0800, Andrew Morton wrote:
> Kurt Garloff <garloff@suse.de> wrote:
> >
> > Diffing in sysctl.c is tricky, using more context is recommended.
> > suid_dumpable ended up in fs/ instead of kernel/ and the reason
> > is likely a patch with too little context.
> 
> It's been in kernel/ since 2.6.13.  What will break if we move it?
> 
> This is security-related.  If we move it we risk unsecuring people's
> machines...

only a very little bit since the default value is "secure", the option
is to make it "insecure"...
but yeah by this time we should just bite the bullet and rename the
variable rather than move it about


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/