Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: sign-file: full functionality with modern LibreSSL
To:     keyrings@vger.kernel.org
References: <f13b4174-bcfa-6569-0601-65a9bfc9bb92@rosalinux.ru>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
From:   Mikhail Novosyolov <m.novosyolov@rosalinux.ru>
Message-ID: <375f18b9-c23a-7f59-4432-374816725a79@rosalinux.ru>
Date:   Sun, 10 May 2020 18:51:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <f13b4174-bcfa-6569-0601-65a9bfc9bb92@rosalinux.ru>
Content-Type: text/plain; charset=utf-8
Content-Language: ru-RU
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

19.03.2020 00:31, Mikhail Novosyolov =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> Current pre-release version of LibreSSL has enabled CMS support,
> and now sign-file is fully functional with it.
>
> See https://github.com/libressl-portable/openbsd/commits/master
>
> To test buildability with current LibreSSL:
> ~$ git clone https://github.com/libressl-portable/portable.git
> ~$ cd portable && ./autogen.sh
> ~$ ./configure --prefix=3D/opt/libressl
> ~$ make
> ~# make install
> Go to the kernel source tree and:
> ~$ gcc -I/opt/libressl/include -L /opt/libressl/lib -lcrypto -Wl,-rpath=
,/opt/libressl/lib scripts/sign-file.c -o scripts/sign-file
>
> Fixes: f8688017 ("sign-file: fix build error in sign-file.c with libres=
sl")
>
> Signed-off-by: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>

I would like to remember about this.

LibreSSL 3.1.1 has been released, and this patch (https://patchwork.kerne=
l.org/patch/11446123/) is required to sign kernel modules using libressl.

Libressl 3.1.1 can sign them with functional parity with OpenSSL.

> ---
> =C2=A0scripts/sign-file.c | 7 ++++---
> =C2=A01 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
> index fbd34b8e8f57..fd4d7c31d1bf 100644
> --- a/scripts/sign-file.c
> +++ b/scripts/sign-file.c
> @@ -41,9 +41,10 @@
> =C2=A0 * signing with anything other than SHA1 - so we're stuck with th=
at if such is
> =C2=A0 * the case.
> =C2=A0 */
> -#if defined(LIBRESSL_VERSION_NUMBER) || \
> -=C2=A0=C2=A0=C2=A0 OPENSSL_VERSION_NUMBER < 0x10000000L || \
> -=C2=A0=C2=A0=C2=A0 defined(OPENSSL_NO_CMS)
> +#if defined(OPENSSL_NO_CMS) || \
> +=C2=A0=C2=A0=C2=A0 ( defined(LIBRESSL_VERSION_NUMBER) \
> +=C2=A0=C2=A0=C2=A0 && (LIBRESSL_VERSION_NUMBER < 0x3010000fL) ) || \
> +=C2=A0=C2=A0=C2=A0 OPENSSL_VERSION_NUMBER < 0x10000000L
> =C2=A0#define USE_PKCS7
> =C2=A0#endif
> =C2=A0#ifndef USE_PKCS7