Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1507511ybk; Sun, 10 May 2020 19:22:43 -0700 (PDT) X-Google-Smtp-Source: APiQypJ80PZ4clP/3BC7h0QpWFGrFjOqJtdBUAmStM8k58j0lryZedYkwyWu/jFsqOnfQSZdGK4E X-Received: by 2002:a05:6402:206f:: with SMTP id bd15mr11937367edb.24.1589163763525; Sun, 10 May 2020 19:22:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589163763; cv=none; d=google.com; s=arc-20160816; b=kcr9GplPDUSBLfUHHuUKIFSiWx6dnAneSh0DYgkO0XzoSHQPEgsvH4XrEnpQJy3KFu QfF8d74hnjQaA6mNmHPkpOuuOki6omeOhbyJ3NmzXP39787x2XiyZdCDTfsSTJj/y9Ev iFoYU/AdszxxgseNjjn5o0TX8nQjGXFYeIA2F7BCRE5LRbYEREG5NrN7a/GlJm+kwfe8 U6DYs7YyH+Db0ekamkI45P05eSzaFu2U0fmqhIdvI2hpo+hktaxR5POoI0t/eTT7xEXN Zkl8cBEV2lRP9DIYDFwXGITjk+0uab3d86E9/b9+28DdSFzwkUCPevvdNLP1/8xgy4sV 1lqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=7j936KbEx3ky4EHJ4M/s+MZ1C3dTY8TYNy8TeswQQFc=; b=d273d09MWIyPFzwMHc9LAfz5Rz+9xFm1JTP/eLM4VY41+3SOfvDDgXdfgmnPeB16R6 4PboM2ZXZSrbmm/gxKt0V/OVVZf/eh2Cfyn4U+0J38V5xwQ+lAyMqysVaWsWGCwuDc3m E7DVlOIpj2ghkOWU2RsbPw+JPFeQaGNdo7FTG5Xkvu865yVjkQ3Y4NpXbtie9tNgR0K8 KA8BEPf4c8fx9UiT4+mf73jp4cfcKZc1mWysSpC7EOHuw92uY++jyC7Se7JrUYVORVPR kVrw1lwsI9WbpYncTnJ0lBuolbE8dgJqgCPveZ7WJ/wEi+bi4uvlerDg3KzERrU12aYw hv5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si5327740ejw.475.2020.05.10.19.22.13; Sun, 10 May 2020 19:22:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729408AbgEKCRN (ORCPT + 99 others); Sun, 10 May 2020 22:17:13 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:49826 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729246AbgEKCRM (ORCPT ); Sun, 10 May 2020 22:17:12 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 02B05291D18D29504945; Mon, 11 May 2020 10:17:09 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 11 May 2020 10:17:02 +0800 From: Kefeng Wang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , , CC: Kefeng Wang , Hulk Robot Subject: [PATCH 02/10] riscv: stacktrace: Fix undefined reference to `walk_stackframe' Date: Mon, 11 May 2020 10:19:53 +0800 Message-ID: <20200511022001.179767-3-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200511022001.179767-1-wangkefeng.wang@huawei.com> References: <20200511022001.179767-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop static declaration to fix following build error if FRAME_POINTER disabled, riscv64-linux-ld: arch/riscv/kernel/perf_callchain.o: in function `.L0': perf_callchain.c:(.text+0x2b8): undefined reference to `walk_stackframe' Reported-by: Hulk Robot Signed-off-by: Kefeng Wang --- arch/riscv/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/stacktrace.c b/arch/riscv/kernel/stacktrace.c index 38141a3c70f7..595342910c3f 100644 --- a/arch/riscv/kernel/stacktrace.c +++ b/arch/riscv/kernel/stacktrace.c @@ -65,7 +65,7 @@ void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, #else /* !CONFIG_FRAME_POINTER */ -static void notrace walk_stackframe(struct task_struct *task, +void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, bool (*fn)(unsigned long, void *), void *arg) { unsigned long sp, pc; -- 2.26.2