Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1580179ybk; Sun, 10 May 2020 22:05:52 -0700 (PDT) X-Google-Smtp-Source: APiQypLYbpjwBjztiCMGLwzMxp3STgrCwQxdQUmLSqnJcjbPEGW5fnu7O3+CF+Ja0ZeyCM4oASkZ X-Received: by 2002:a17:906:b750:: with SMTP id fx16mr8567984ejb.35.1589173551957; Sun, 10 May 2020 22:05:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589173551; cv=none; d=google.com; s=arc-20160816; b=p86a7dvovm3oGPYbVFLVvbjMDiWOrIuF1//kCc7vbPBQCqqqgSJ3O+0Tmwiy7tXABf ErBScnJFOGt9bU05ZqVnBmXKXIXQq8rGb3D8dhcnGmOHw8RtIqvplI0REEkfyap5vFhm lz+gfPs5DWscTQEZK/QzI0tAXOFbWjfAKkud9AVEJ8HAzmXgtC9Yu01KxIEL1fN0WoS+ 9M2l1vbIFKwJ3OPRpcmDpMj5IV+7G2vcM1yjIDNN3kOpycX4p7KhlpuvGM+ysa5gy0mw zGzaHTE8zVjXPYgOBQ+fgrWg3nFfkSaLBjVxqVUSudE0mzEYiATqYTSwnQnKT8dYskIy Gpyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2VnGexfw0Gk5ScJEMgb0uXAXdUPbiKdWAWXi79WcGHU=; b=IfzP/TtCW57TAJBhykHDy7U8V4ugNKbkNjEHVb/Bo4lCZ6sVLZ+zf7YmVphRsxeaVt Vnu5b4QZig2H/0FVmU8ukJ7NOa82Ty9w1yYsapupJn0NUwCzy9IBsU+fzv2yePPsUe+G BrwzvffkUhaSfj6Ez2k9SliAssJRKGc/IrvR8hV0/aSVO7WVVDUTyztG4Tev2qoXEjyM wbQROqXBPDb1ZY9QCy/OuUe7SPzk82uvJuGszMNf9ai7gSkofwGOdIwCCG257YWDwUeK sGrY9d5mayDcIffIWUq1kHGVg2TrZ96o0rAbc7lcFrDhSXWdM3E0KMEjllRC9E1OibQk Fdtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=F9HiS8pW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si1897611ejr.172.2020.05.10.22.05.24; Sun, 10 May 2020 22:05:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=F9HiS8pW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgEKFDW (ORCPT + 99 others); Mon, 11 May 2020 01:03:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:47754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgEKFDW (ORCPT ); Mon, 11 May 2020 01:03:22 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AAE62082E; Mon, 11 May 2020 05:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589173402; bh=AEQ5/eHF4mOqL/y16T898LganyocNlGAK0Fzmso4HzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F9HiS8pWarfCpH7Ng0cm9R9PYx1ieS/AWHG+N8Y7CCrLII34xmqET1r7qbTQXyGpi vDsjQ1tDTzEvSmfFo7kyoo7F2C5ka95CW9qiVZygzfum7+A2L2WZd70FhFiaetZlao +6y1HWIgdnjcn7XkeJQOBMBz5/ofGjPIqlE9Dg9Q= Date: Mon, 11 May 2020 01:03:21 -0400 From: Sasha Levin To: Andi Kleen Cc: Vegard Nossum , linux-kernel@vger.kernel.org, tglx@linutronix.de, luto@kernel.org, tony.luck@intel.com, chang.seok.bae@intel.com Subject: Re: [PATCH v10 00/18] Enable FSGSBASE instructions Message-ID: <20200511050321.GO13035@sasha-vm> References: <20200423232207.5797-1-sashal@kernel.org> <5a6a0ef5-4dfc-d0b1-9181-5df4211cfcd9@oracle.com> <20200511004842.GJ3538@tassilo.jf.intel.com> <20200511005028.GA226400@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200511005028.GA226400@tassilo.jf.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2020 at 05:50:28PM -0700, Andi Kleen wrote: >> So this is a check that checks if you're running in user mode if >> you have a debug trap with single step, but somehow it triggered >> for a user segment. >> >> Probably the regs got corrupted. >> >> Sasha, I suspect you're missing a mov %rsp,%rdi somewhere in the >> debug entry path that sets up the regs argument for the C code. > >... Ah never mind. Thomas has a better explanation. FWIW, this series was heavily tested for the past few months to the point that we're comfortable in enabling it for 3rd party users on Azure: https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1877425. -- Thanks, Sasha