Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1693142ybk; Mon, 11 May 2020 01:52:22 -0700 (PDT) X-Google-Smtp-Source: APiQypLhLiySobUb7E40RBrCnFqI1XNeXVDrbTrUg0g758JLyi2sDlVIANqhUbvjONtTEoyBK3eX X-Received: by 2002:a05:6402:b4c:: with SMTP id bx12mr13004744edb.247.1589187142421; Mon, 11 May 2020 01:52:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589187142; cv=none; d=google.com; s=arc-20160816; b=TuiQBz6Y+qYiHwofhBZLEnoLhAjKuC5/9sdeNVOXajOiz1vMppOWKuf8mKDGMoMJvC u2VzUjBPVL1p8bz+N27rUXBgeTAgwWQpW/xDZlOpmIEaLm8HyqqiLWxEOzLRcygcO5aJ 4v5l8+uu8GhGQRgJFVE7AmbVzUEvpUksGGtRrS8ISx9TaTWfmVrZxqhO4I1FW1ovEtqu aoIkAVfOVbJajbI63Nx4mVlaW382TBmteBW7jdyEH7WjzV6FWl7iMuPXaFaK4/o28oiS grj5JPlXJaj/q1MS5GyRmhzboN4WG1NdM23v32lrK7NL+2dGf1d+DxYHsgK04PQZdPga gnVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=8akJMarKmQ+8zkqjfba4nwsi4ov0ddlgUS84vZANn10=; b=dYcxHlWr0cLChIUDrGu/nwrRx7MoAfizp+0ZxFB/4CKEOfo29Cdu/eKVDKPrD/+4wZ lbqHWpBURbnMwPLFuxoSSY9XJgigLh5cR+0VVFSqquZQcl+cFgm7x2KU3Wd9GrxkZGmv yirJuVe2QZYUyEV6rUv9Zo2SMWfiawJLChyJ5c+PjlZ5qg0XUHUMQRtz6sGV5gJzYG3l gNN/UqaidYr96BVksc0+9RUOl5TBAaUYQW0SHS//aW+ovWXvm7IGe8ZnCIfCE97HXwFX vAA0SyLuHuEc72x52CUgqNs62e/20od9kszV9Hh6FWMkPImGnZGZamTQ6VQUTpr6alZj 2DMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw21si5202782ejb.158.2020.05.11.01.51.46; Mon, 11 May 2020 01:52:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729226AbgEKIt6 (ORCPT + 99 others); Mon, 11 May 2020 04:49:58 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:36900 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728562AbgEKIt5 (ORCPT ); Mon, 11 May 2020 04:49:57 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id BB63AB93F3FEEFD6C057; Mon, 11 May 2020 16:49:53 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 11 May 2020 16:49:45 +0800 From: Xiongfeng Wang To: , CC: , , Subject: [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode' Date: Mon, 11 May 2020 16:43:46 +0800 Message-ID: <1589186626-17243-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When I cat module parameter 'dma_mode' by sysfs, it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode memcpy[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- drivers/media/pci/tw686x/tw686x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c index 74ae4f0..bfc61da 100644 --- a/drivers/media/pci/tw686x/tw686x-core.c +++ b/drivers/media/pci/tw686x/tw686x-core.c @@ -71,7 +71,7 @@ static const char *dma_mode_name(unsigned int mode) static int tw686x_dma_mode_get(char *buffer, const struct kernel_param *kp) { - return sprintf(buffer, "%s", dma_mode_name(dma_mode)); + return sprintf(buffer, "%s\n", dma_mode_name(dma_mode)); } static int tw686x_dma_mode_set(const char *val, const struct kernel_param *kp) -- 1.7.12.4