Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1851048ybk; Mon, 11 May 2020 05:59:17 -0700 (PDT) X-Google-Smtp-Source: APiQypJ5xatiDkbWRI+fBFBJTh5wqjtD5l4WfpedsSlUCzzkWreVgcHT+6Hl6Lq+fnPFCN//GTVn X-Received: by 2002:a17:906:405a:: with SMTP id y26mr12892834ejj.31.1589201956924; Mon, 11 May 2020 05:59:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589201956; cv=none; d=google.com; s=arc-20160816; b=IHVbQFP60e00x2CJ5nKtJyVykol+5Zlu7J7U/pOoa+I7O0h3mOn5csOOBMCGZynWK3 KyMo0ur/xcOt38zmcVfNZW74vq/h8OTkYTQeKrZ6GLhgx+eWSg01JQSyJjyvYB8ahQU6 AdCTMdl1QeYPxfXuRz7jXSS2ERxX9kv+X37JoZYfatoo3PxPdWQxom5vK2hbKV3OUwZx e4HYF6uf77inbSSkcTvCULdEW8UikDXLKRXiCtmXBiaSGKaZlhS3FcLnAiAtth8Ewtw/ 18NmfAMeemwY+nVC3fF7pp99L6tNiuUaJbFJvWqp7II6L8gi2FkJnF97xrON8+M7LZDc xmig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+tq+oIg6yKfVpEP47QBE3fVlR2hUsQZwefsLPbgWGTY=; b=EQJWSon0K/+M7/4WYCOGZusCdSYPuCbG0zLp4PrXC2Y0i1F++LrQsHypTDemJfoMCk 3pXqssUs29mFXwCtr05LcFnU6jFhRnz093CvxSadue9zKddPwkoYByVto+vC6U9ZkfdP 3kPl7nZBpFIrKPa6FVA16TYARV9hlHlqKgr9/ZOByMGW8guVxnpGToRviT4+LKnKO27V O2hvuYUDmB2wW6HcGM6S2P0UiyZN0VrVlHNx4A73B/yTvB4iwjjR1BunpW7EbVtqgxSS pfQbTMynP3FOgMtLvqyKBQVHwDCG+mxy3enaA5BdB/9ZOkhBv32O7J5o9mvX0hVgbG7s jXeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=etOzo4t5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y43si4025279ede.404.2020.05.11.05.58.53; Mon, 11 May 2020 05:59:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=etOzo4t5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729820AbgEKMzX (ORCPT + 99 others); Mon, 11 May 2020 08:55:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:55616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgEKMzX (ORCPT ); Mon, 11 May 2020 08:55:23 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8853F20722; Mon, 11 May 2020 12:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589201722; bh=fI1SN20EX/4GtN+QbDDKwe0uGIQ2raxx/8QClojgIe8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=etOzo4t5b4u6f5ics6j3+lhzkrKUN/2V1AICzngaF8C0uUKuW8Mg5PQfavbLP/Ovc sB1hhGd6UUAkEK/1bnpkLITxHhaSbNAe+g5FLXAxJwbL26/zxpkAUIqj2BqmopS1Ia y9wb2cFrwTuWkWbxBEuqFfsqITcTFm8x4t6TYtAw= From: Will Deacon To: Luke Nelson , bpf@vger.kernel.org Cc: catalin.marinas@arm.com, Will Deacon , Thomas Gleixner , Christoffer Dall , linux-arm-kernel@lists.infradead.org, Andrii Nakryiko , Zi Shen Lim , Alexei Starovoitov , John Fastabend , Marc Zyngier , Mark Rutland , Ard Biesheuvel , Luke Nelson , Song Liu , Martin KaFai Lau , Daniel Borkmann , KP Singh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xi Wang , Yonghong Song , clang-built-linux@googlegroups.com, Alexios Zavras Subject: Re: [PATCH bpf-next v2 0/3] arm64 BPF JIT Optimizations Date: Mon, 11 May 2020 13:55:08 +0100 Message-Id: <158919609995.133008.6274359604607907270.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200508181547.24783-1-luke.r.nels@gmail.com> References: <20200508181547.24783-1-luke.r.nels@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2020 11:15:43 -0700, Luke Nelson wrote: > This patch series introduces several optimizations to the arm64 BPF JIT. > The optimizations make use of arm64 immediate instructions to avoid > loading BPF immediates to temporary registers, when possible. > > In the process, we discovered two bugs in the logical immediate encoding > function in arch/arm64/kernel/insn.c using Serval. The series also fixes > the two bugs before introducing the optimizations. > > [...] Applied to arm64 (for-next/bpf), thanks! [1/3] arm64: insn: Fix two bugs in encoding 32-bit logical immediates https://git.kernel.org/arm64/c/579d1b3faa37 [2/3] bpf, arm64: Optimize AND,OR,XOR,JSET BPF_K using arm64 logical immediates https://git.kernel.org/arm64/c/fd49591cb49b [3/3] bpf, arm64: Optimize ADD,SUB,JMP BPF_K using arm64 add/sub immediates https://git.kernel.org/arm64/c/fd868f148189 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev