Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 May 2020 15:03:27 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     bsegall@google.com
Cc:     Huaixin Chang <changhuaixin@linux.alibaba.com>,
        chiluk+linux@indeed.com, linux-kernel@vger.kernel.org,
        mingo@redhat.com, pauld@redhead.com, vincent.guittot@linaro.org
Subject: Re: [PATCH v2] sched: Defend cfs and rt bandwidth quota against
 overflow
Message-ID: <20200511130327.GA2978@hirez.programming.kicks-ass.net>
References: <xm26k126kkma.fsf@google.com>
 <20200425105248.60093-1-changhuaixin@linux.alibaba.com>
 <xm26ftcolr3p.fsf@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xm26ftcolr3p.fsf@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 27, 2020 at 11:29:30AM -0700, bsegall@google.com wrote:
> Huaixin Chang <changhuaixin@linux.alibaba.com> writes:
> 
> > When users write some huge number into cpu.cfs_quota_us or
> > cpu.rt_runtime_us, overflow might happen during to_ratio() shifts of
> > schedulable checks.
> >
> > to_ratio() could be altered to avoid unnecessary internal overflow, but
> > min_cfs_quota_period is less than 1 << BW_SHIFT, so a cutoff would still
> > be needed. Set a cap MAX_BW for cfs_quota_us and rt_runtime_us to
> > prevent overflow.
> 
> Reviewed-by: Ben Segall <bsegall@google.com>

Thanks!