Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 May 2020 16:13:10 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Andrew Lunn <andrew@lunn.ch>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Michal Kubecek <mkubecek@suse.cz>
Cc:     David Jander <david@protonic.nl>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>, mkl@pengutronix.de,
        Marek Vasut <marex@denx.de>,
        Christian Herber <christian.herber@nxp.com>
Subject: signal quality and cable diagnostic
Message-ID: <20200511141310.GA2543@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andrew,

First of all, great work! As your cable diagnostic patches are in
net-next now and can be used as base for the follow-up discussion.

Do you already have ethtool patches somewhere? :=) Can you please give a
link for testing?

I continue to work on TJA11xx PHY and need to export some additional
cable diagnostic/link stability information: Signal Quality Index (SQI).
The PHY data sheet describes it as following [1]:
================================================================================
  6.10.3   Link stability

The signal-to-noise ratio is the parameter used to estimate link
stability. The PMA Receive function monitors the signal-to-noise ratio
continuously. Once the signal-to-noise ratio falls below a configurable
threshold (SQI_FAILLIMIT), the link status is set to FAIL and
communication is interrupted. The TJA1100 allows for adjusting the
sensitivity of the PMA Receive function by configuring this threshold.
The microcontroller can always check the current value of the
signal-to-noise ratio via the SMI, allowing it to track a possible
degradation in link stability.
================================================================================

Since this functionality is present at least on TJA11xx PHYs and
mandatory according to Open Alliance[2], I hope this functionality is
present on other 100/1000Base-T1 PHYs. So may be some common abstraction
is possible. What would be the best place to provide it for the user
space? According to the [2] SQI, is the part of Dynamic Channel Quality
(DCQ) together with Mean Square Error (MSE) and Peak MSE value (pMSE).

[1] https://www.nxp.com/docs/en/data-sheet/TJA1100.pdf
[2] http://www.opensig.org/download/document/218/Advanced_PHY_features_for_automotive_Ethernet_V1.0.pdf
    http://www.opensig.org/download/document/225/Open_Alliance_100BASE-T1_PMA_Test_Suite_v1.0-dec.pdf

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |