Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 May 2020 22:16:55 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     "Biwen Li (OSS)" <biwen.li@oss.nxp.com>
Cc:     Ran Wang <ran.wang_1@nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiafei Pan <jiafei.pan@nxp.com>
Subject: Re: [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
Message-ID: <20200511141649.GA26831@dragon>
References: <20200407064251.39244-1-biwen.li@oss.nxp.com>
 <20200426131751.GC30501@dragon>
 <DB6PR0401MB2438A8B634DBE15FADD3CFB18FA20@DB6PR0401MB2438.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DB6PR0401MB2438A8B634DBE15FADD3CFB18FA20@DB6PR0401MB2438.eurprd04.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 08, 2020 at 09:35:47AM +0000, Biwen Li (OSS) wrote:
> > 
> > On Tue, Apr 07, 2020 at 02:42:48PM +0800, Biwen Li wrote:
> > > From: Biwen Li <biwen.li@nxp.com>
> > >
> > > The patch adds ftm_alarm0 DT node for Soc LX2160A
> > > FlexTimer1 module is used to wakeup the system in deep sleep
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 18
> > > ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > index e5ee5591e52b..e0d8d68ce070 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > @@ -16,6 +16,10 @@
> > >  	#address-cells = <2>;
> > >  	#size-cells = <2>;
> > >
> > > +	aliases {
> > > +		rtc1 = &ftm_alarm0;
> > > +	};
> > > +
> > >  	cpus {
> > >  		#address-cells = <1>;
> > >  		#size-cells = <0>;
> > > @@ -768,6 +772,20 @@
> > >  			timeout-sec = <30>;
> > >  		};
> > >
> > > +		rcpm: rcpm@1e34040 {
> > 
> > Keep the node sort in unit-address.  Also, try to use a generic node name.
> Hi Shawn,
> Sorry for late reply.
> The node sort will be updated in v2.
> rcpm is called as Run Control and Power Management. Don't
> Have a generic node name, any suggestions?

It sounds like some sort of power controller, so maybe 'power-controller'?

Shawn