Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1951391ybk; Mon, 11 May 2020 08:15:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKRbrR+FvyOXrsM13nKgkUOlYU1gA9LrtDDQaX/P3o2nqHBguIbQa5mKxiP0Kc7uqs7Id6 X-Received: by 2002:aa7:d492:: with SMTP id b18mr1559481edr.28.1589210116620; Mon, 11 May 2020 08:15:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589210116; cv=none; d=google.com; s=arc-20160816; b=Msv9Xx+9+v1N44NkE2xFJf7n4wNxamHoqF2vHhRlJK9r3lhPEqMVHIixSdES1F05YL GiVX3EGn4mpY3IHxoVyrvAMmYuZGxyVa+v2C2CCpbWJLMyqJuFwj70HQCXTjYu62sG1M 2Kn6hl7EtqSqsHnN6M80tQkvRro8mMUAp/v/XeAG6T5Yo9ZPYXrcXi4miT9RPJ0vLR8k C18QDE+2IP2ffkbIqxOB/G+1FYPBU1VPsupYvnCRgv0b5TdZ7qfvmUiIqVCdFLkUMlya 62LgiXlrXdO6XEWcp1jcjGnm8M1OWml9VgYoQOMRtAJIdHjT+86NSKWmxwy6FuYFQnUz KMhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7Z+RpUw3foq2DoulpysZqJ3WImdCphBXYhljKnr3/yI=; b=uJVQcwheFcgzKRuOGmpQc2ICNyL6NVZyiE0GG0YwFUXkGWrS8zwXsd2G0Qkb1jbbwP hKBTcIR/J5aXYo0i8j8cNN/ZyxLOjpJ78lvH6VZUlN9L5BP2Mt7HNt7m1zWxpvDHdLxT xYzIhHkmSdboTGU3X87ER5HmtpYODQljnfFcFiUYbP3ehfrUCtmeQXuKZ2eir0Ynb7s7 pAfjRme0egI642qeGuU0IhNU6JDMw19XpLFBiTAUl+lTElSNxKwHAjbZVxSr3InO0lph 8SdZfo0M9Pn2oCYQ6Vpvun/e+c/E+rJfXVNkovg5Ef6zyvQ+AsGH9ll+/7sA9XW0L9Qg TXLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si5962122edw.356.2020.05.11.08.14.53; Mon, 11 May 2020 08:15:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729977AbgEKPL2 (ORCPT + 99 others); Mon, 11 May 2020 11:11:28 -0400 Received: from verein.lst.de ([213.95.11.211]:36580 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729439AbgEKPL1 (ORCPT ); Mon, 11 May 2020 11:11:27 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2865568BFE; Mon, 11 May 2020 17:11:21 +0200 (CEST) Date: Mon, 11 May 2020 17:11:20 +0200 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel , Jessica Yu , Michal Simek , the arch/x86 maintainers , alpha , Linux Kernel Mailing List , Linux ARM , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , sparclinux , Linux-Arch , Linux MM , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux FS Devel Subject: Re: [PATCH 31/31] module: move the set_fs hack for flush_icache_range to m68k Message-ID: <20200511151120.GA28634@lst.de> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-32-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2020 at 09:40:39AM +0200, Geert Uytterhoeven wrote: > On Sun, May 10, 2020 at 9:57 AM Christoph Hellwig wrote: > > > > flush_icache_range generally operates on kernel addresses, but for some > > reason m68k needed a set_fs override. Move that into the m68k code > > insted of keeping it in the module loader. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven Btw, do you know what part of flush_icache_range relied on set_fs? Do any of the m68k maintainers have an idea how to handle that in a nicer way when we can split the implementations?