Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 May 2020 10:46:47 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Chunyan Zhang <chunyan.zhang@unisoc.com>
Subject: Re: [PATCH] coresight: tmc: mark coresight_tmc_groups with static
Message-ID: <20200511164647.GA13202@xps15>
References: <20200508091340.11711-1-zhang.lyra@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200508091340.11711-1-zhang.lyra@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Chunyan,

On Fri, May 08, 2020 at 05:13:40PM +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> 
> Sparse reports a warning like:
> drivers/hwtracing/coresight/coresight-tmc.c:364:30: warning: symbol
> 'coresight_tmc_groups' was not declared. Should it be static? [sparse]
> 
> coresight_tmc_groups is used in the local file only, so it should be
> marked with static.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
>  drivers/hwtracing/coresight/coresight-tmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
> index 1cf82fa..39fba1d 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc.c
> @@ -361,7 +361,7 @@ static ssize_t buffer_size_store(struct device *dev,
>  	.name = "mgmt",
>  };
>  
> -const struct attribute_group *coresight_tmc_groups[] = {
> +static const struct attribute_group *coresight_tmc_groups[] = {

This has already been addressed by Stephen [1] earlier in this cycle.  It is
currently in linux-next and will be submitted for inclusion in the next cycle.

Thanks,
Mathieu

[1]. https://www.spinics.net/lists/arm-kernel/msg801714.html

>  	&coresight_tmc_group,
>  	&coresight_tmc_mgmt_group,
>  	NULL,
> -- 
> 1.9.1
>