Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200504190526.84456-1-peterx@redhat.com> <20200505013929.GA17225@linux.intel.com>
 <20200505141245.GH6299@xz-x1> <20200511160537.GC24052@linux.intel.com>
In-Reply-To: <20200511160537.GC24052@linux.intel.com>
From:   Oliver Upton <oupton@google.com>
Date:   Mon, 11 May 2020 10:04:29 -0700
Message-ID: <CAOQ_Qsi-50zLtq8nKeUN8wYKkiq9TkX9fcNHwzZ_F5JX0qJp-g@mail.gmail.com>
Subject: Re: [PATCH] KVM: Fix a warning in __kvm_gfn_to_hva_cache_init()
To:     Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
        kvm list <kvm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Tony Cook <tony-cook@bigpond.com>, zoran.davidovac@gmail.com,
        euloanty@live.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 11, 2020 at 9:05 AM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:
>
> +cc a few other people that have reported this at one time or another.
>
> On Tue, May 05, 2020 at 10:12:45AM -0400, Peter Xu wrote:
> > On Mon, May 04, 2020 at 06:39:29PM -0700, Sean Christopherson wrote:
> > > On Mon, May 04, 2020 at 03:05:26PM -0400, Peter Xu wrote:
> > > > GCC 10.0.1 gives me this warning when building KVM:
> > > >
> > > >   warning: =E2=80=98nr_pages_avail=E2=80=99 may be used uninitializ=
ed in this function [-Wmaybe-uninitialized]
> > > >   2442 |  for ( ; start_gfn <=3D end_gfn; start_gfn +=3D nr_pages_a=
vail) {
> > > >
> > > > It should not happen, but silent it.
> > >
> > > Heh, third times a charm?  This has been reported and proposed twice
> > > before[1][2].  Are you using any custom compiler flags?  E.g. -O3 is =
known
> > > to cause false positives with -Wmaybe-uninitialized.
> >
> > No, what I did was only upgrading to Fedora 32 (which will auto-upgrade=
 GCC),
> > so it should be using the default params of whatever provided.
> >
> > >
> > > If we do end up killing this warning, I'd still prefer to use
> > > uninitialized_var() over zero-initializing the variable.
> > >
> > > [1] https://lkml.kernel.org/r/20200218184756.242904-1-oupton@google.c=
om
> > > [2] https://bugzilla.kernel.org/show_bug.cgi?id=3D207173
> >
> > OK, I didn't know this is a known problem and discussions going on.  Bu=
t I
> > guess it would be good to address this sooner because it could become a=
 common
> > warning very soon after people upgrades gcc.
>
> Ya, others are hitting this as well.  It's especially painful with the
> existence of KVM_WERROR.
>
> Paolo, any preference on how to resolve this?  It would appear GCC 10 got
> "smarter".

Seems that doing absolutely nothing was the fix here :) See:

78a5255ffb6a ("Stop the ad-hoc games with -Wno-maybe-initialized")

--
Thanks,
Oliver