Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dky4Y82KMqtHnCxmB6pd8U51t9Kv17sSS/9XuMFWt+HD9F0Ou6jSW9Xz36rg5n0mk/xNTqUT+6
 O16oi/N9tOTA==
IronPort-SDR: UriJ4Mj+W1dUj4SAvvtpUe2eoHnCT1YifIAyVeIXqTp9uaMsPTUvo4cyNtBzMjm2ajwrhM0nUr
 FrG7Q4XFCzEQ==
Subject: Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support
To:     Vinod Koul <vkoul@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, tiwai@suse.de,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
        broonie@kernel.org, srinivas.kandagatla@linaro.org,
        jank@cadence.com, mengdong.lin@intel.com,
        slawomir.blauciak@intel.com, sanyog.r.kale@intel.com,
        rander.wang@linux.intel.com, bard.liao@intel.com
References: <20200429185145.12891-1-yung-chuan.liao@linux.intel.com>
 <20200429185145.12891-4-yung-chuan.liao@linux.intel.com>
 <20200511063227.GS1375924@vkoul-mobl>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <e214d308-1b92-a7a5-3c76-da05dca99cc5@linux.intel.com>
Date:   Mon, 11 May 2020 14:00:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200511063227.GS1375924@vkoul-mobl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


>> +	md = &bus->md;
>> +	md->dev.bus = &sdw_bus_type;
>> +	md->dev.type = &sdw_master_type;
>> +	md->dev.parent = parent;
>> +	md->dev.of_node = parent->of_node;
>> +	md->dev.fwnode = fwnode;
>> +	md->dev.dma_mask = parent->dma_mask;
>> +
>> +	dev_set_name(&md->dev, "sdw-master-%d", bus->link_id);
> 
> This give nice sdw-master-0. In DT this comes from reg property. I dont
> seem to recall if the ACPI/Disco spec treats link_id as unique across
> the system, can you check that please, if not we would need to update
> this.
Table 3 in the Disco for Soundwire 1.0 spec: "all LinkID values are 
relative to the immediate parent Device."

There isn't any known implementation with more than one controller.