Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH bpf] samples: bpf: fix build error
To:     Matteo Croce <mcroce@redhat.com>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Joe Stringer <joe@ovn.org>, Jakub Kicinski <kuba@kernel.org>
References: <20200511113234.80722-1-mcroce@redhat.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <0dd7c40b-c80b-9149-f022-d8113b77558a@fb.com>
Date:   Mon, 11 May 2020 13:32:05 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.8.0
In-Reply-To: <20200511113234.80722-1-mcroce@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from macbook-pro-52.local.dhcp.thefacebook.com (2620:10d:c090:400::5:3585) by BY3PR10CA0024.namprd10.prod.outlook.com (2603:10b6:a03:255::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Mon, 11 May 2020 20:32:19 +0000
X-Originating-IP: [2620:10d:c090:400::5:3585]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: af8a0372-f898-4b95-ec5b-08d7f5ea6713
X-MS-TrafficTypeDiagnostic: BYAPR15MB2760:
X-Microsoft-Antispam-PRVS: <BYAPR15MB2760E1BF200D5830E77540A3D3A10@BYAPR15MB2760.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:293;
X-Forefront-PRVS: 04004D94E2
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: fOGwj1I+ISGl9P+PtWPlYZtlm+UX0P8NtFpqEfywZLUiV2LatwPJIl9Evhhh0bTj2uH5APz7CqQlaljeyJLNs2KVnoqN3lYGW9Ry76RB11/gF861eyn4ZtLrnl8WMBvIlupzPTm0Injz5vws8RtNM6EMpGIpLv43YwTCOvlVgr/FD6NwrQfDPtxiJyBr25Y8/JURkTfjfdwEFk+i1qe1M3BzYP+HdTnJ6jeWN09+1Wl75UO2rBY95RfujztvvTlxOqHS7yT22+Un5ytHsva8cU3D2OCM6lew6u9QfGEM9Zun+2udJCchddLSISNoMPj1BZZe7dfCyuAFFWalJvBAkKE1/SNWEkNQGyjYN+LFMpR/F9/LVGGFWkkHo+u+/yparikn2WPWHjFekpecbDKkR6uX52oE2WEFwIMikChyX1ePChi8s4ob87S5upBU6qz0Cju3DZl01ybgSey7It6D9MPoQAY+ZrARukiKnHsHoBpVsiBuPHIo+V1DuXjB4i1oI7Us1q5AAcAyeTupjnm+3sM+tcL9iFBhehiIf5Z1utl/VK4BBn10W2SWOZe3hfiX
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4088.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(346002)(39860400002)(396003)(366004)(136003)(33430700001)(4326008)(31686004)(2616005)(4744005)(66946007)(86362001)(66556008)(2906002)(6666004)(31696002)(478600001)(6486002)(66476007)(8676002)(6512007)(8936002)(186003)(316002)(5660300002)(53546011)(54906003)(33440700001)(6506007)(52116002)(36756003)(16526019)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: FoPrCzB6PtDLfBAjWj68f9+ODydIqzms9/AcPPr+TMtu07TXtujU1BZHFTHj6sAPE0sqEUufbPvHwVVLk9ny3jvfNrfuOwtQnt4FwtP4l8dWxsW9NK8n39JODoKYLxD6gECCqBOHiO12B7Oyi/Kx8N0DIa2I31eBR+2p0usv3eBogi/h646aSxJ7+EdPY1T2hHgVXynDXww42MtoU6u4S/3K2gAv0K7ko8R9QC3vqS+dY5qB7IKtapKuTTPYnB8G31Knzli7FuccuaGz78zvrTGOivwzLb5GH8KPtlAceJwHB07ZouhTos7IM/GnvzxDGxs9m2UPFjXS6Gu2QNJe3j8UckVnsO5qBiDD88KJHjNsrPM8oM5pN41CFxWE0MYb6jx2Ii9xDYS9tpFc8Mz0sZel9nCi3X9SmafniMDDxpC9p7XnP43+7KQN0UTVO9XVfk24TIGL3fUJgvnZS0t3m1kQcZmiNRhDGEBflVuNxBmCsAzuGZLZnu3gTOUYVqNa0ai89yWCQJ99gTaCBpRqjg==
X-MS-Exchange-CrossTenant-Network-Message-Id: af8a0372-f898-4b95-ec5b-08d7f5ea6713
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2020 20:32:19.9154
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QQOvorZmp8HlDlG9ag3Ho3GGZuQ/UPIZOIZT5Nx//gmbooVottPGT08h0tHZnNvy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2760
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676
 definitions=2020-05-11_10:2020-05-11,2020-05-11 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 clxscore=1011
 mlxlogscore=825 priorityscore=1501 lowpriorityscore=0 suspectscore=0
 adultscore=0 impostorscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2003020000 definitions=main-2005110156
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/11/20 4:32 AM, Matteo Croce wrote:
> GCC 10 is very strict about symbol clash, and lwt_len_hist_user contains
> a symbol which clashes with libbpf:
> 
> /usr/bin/ld: samples/bpf/lwt_len_hist_user.o:(.bss+0x0): multiple definition of `bpf_log_buf'; samples/bpf/bpf_load.o:(.bss+0x8c0): first defined here
> collect2: error: ld returned 1 exit status
> 
> bpf_log_buf here seems to be a leftover, so removing it.
> 
> Signed-off-by: Matteo Croce <mcroce@redhat.com>

Acked-by: Yonghong Song <yhs@fb.com>