Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2226305ybk; Mon, 11 May 2020 15:28:22 -0700 (PDT) X-Google-Smtp-Source: APiQypKPK0nlA645sdUBsuMLUSvliyLSM1Qhj5gWazr/B4GtHvajHsNsVM4qiyfa4Ln3OQp2OqMI X-Received: by 2002:a17:906:95cb:: with SMTP id n11mr12721635ejy.182.1589236102221; Mon, 11 May 2020 15:28:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589236102; cv=none; d=google.com; s=arc-20160816; b=OdzTZKheprl7/fj/DwgqfsRBhLYvGIrHLkm4TCcgg0FMPgvAZrHMbx8Hg53MJhXfI7 rqRH1SIVoy5H9AVz2PhmHjqftIXkGK4LxQzw3PAiK+w4s5Es2Sqc+iywpFA6cdKQDbm0 sOKOaYer0beNKsNEhfRxNOaU5gm+6rA9zJXFJWcgYqqEOyPzQVaMrADPE0SGlIdqI402 Peub5Rii8EjKP/Gqlol0zGO4Yva/yIYZeDZgLJe1s9Gz+NaoWjPkkAGM1ajgQTGJJM1c i0CoUrp/1GlnOu3XkICyXKDep4GyyQwCEfsnsMh8tYNytz0kFsk72Bv4YE8EH3BBq3TT 3VTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QvaxpqAOG9RnWvaCfYYP2fpuftRhg/t8uSRu7E32TuQ=; b=RXQYIYUa5g4/P75bf+hz6xjXXH8ZkeOSlaxasXgMtozdsAM+iiPyOnEgmeSGQLfm9Z N8bN9TPhmAUen7pur22GVxJmHTR3xhx3R+24Q+P0s55ZLN+eZV40c4dgjih8Mx/j5tjS +cBHa3MbRNuzNl38Z8UKc4hQ7BloYLYIp5CFIk7bNjAiqmR3VHzRSKa/Qhre1BqOXzb1 PoGzNN7QswyQMBE0H3+P0z2PmHp7FtG88M1VtwsSb/gbeaBx97+1XdpijE1buQ8c7LP5 eJM2ClbgDxtf/RGNHs/XraffuHsb+LmbGcBVN5S6+c4M00KhjLMAiIWgVGvLb3j7RC0p aZoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Pe7YR+b3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v12si7130399edb.234.2020.05.11.15.27.58; Mon, 11 May 2020 15:28:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Pe7YR+b3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725854AbgEKWYN (ORCPT + 99 others); Mon, 11 May 2020 18:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726553AbgEKWYN (ORCPT ); Mon, 11 May 2020 18:24:13 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28997C05BD09 for ; Mon, 11 May 2020 15:24:13 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id q24so8438525pjd.1 for ; Mon, 11 May 2020 15:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QvaxpqAOG9RnWvaCfYYP2fpuftRhg/t8uSRu7E32TuQ=; b=Pe7YR+b338sDJoO+XPIuxNX60nLt75l2VTRDebHqRLmJt9h1yK4Rapmdcyoyh8FrXi 3FEeVdBp1hFpjkSej5hGNFz5+cCHNg6DeNgMNrCLAOApXzVtZuQi6lIz5zxiKPdwGJ3V Syh/TrNkjs76R08MkAtq8MqryvycOESpiNiyw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QvaxpqAOG9RnWvaCfYYP2fpuftRhg/t8uSRu7E32TuQ=; b=bNyyJ0PdtEWADhVqqBLFIO9mhh4R+6PiH1BgXUqRaD11PXMOOUqlRROyDfoTUUanLf jqxx8HuUHKZ4twelLaOKTOY7kTWwHQIXz9V1trCRXPOzDzFYfAOCgYl6GOYqAdGzf6j+ IcPTqnYBBPejpkUwchXQtUWKWnMEG0FdtTKYF6s6G7NzsJIkfGeQmQXvtvkVqwYEXUu/ v3Or88qKDPRtJgixYTlZ5Q3vQ9oScQJ5XS2Ww+S5j2FkVwortj0bp6cUtEp1RiYaHqdT w43cEfygvJ56n0e1C/B1DppJOweE2bacJa2x/SY7n6L6FgihfvlYVRnHL6wMrCjxiNlV RM+w== X-Gm-Message-State: AGi0PuYfwab0ytQlhX3KKDcVMdMuwdc7ametg/ZZEzRzll97J5wRbKb/ N+4ZYv/pHze9iVk/G9c1bq3c7w== X-Received: by 2002:a17:90b:2385:: with SMTP id mr5mr26301393pjb.172.1589235852612; Mon, 11 May 2020 15:24:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s123sm10145294pfs.170.2020.05.11.15.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 15:24:11 -0700 (PDT) Date: Mon, 11 May 2020 15:24:10 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Jann Horn , Greg Ungerer , Rob Landley , Bernd Edlinger , linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton , Casey Schaufler , linux-security-module@vger.kernel.org, James Morris , "Serge E. Hallyn" , Andy Lutomirski Subject: Re: [PATCH 5/5] exec: Move the call of prepare_binprm into search_binary_handler Message-ID: <202005111517.27E34BB6@keescook> References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87sgga6ze4.fsf@x220.int.ebiederm.org> <87v9l4zyla.fsf_-_@x220.int.ebiederm.org> <873688zygz.fsf_-_@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <873688zygz.fsf_-_@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 09, 2020 at 02:42:52PM -0500, Eric W. Biederman wrote: > > The code in prepare_binary_handler needs to be run every time > search_binary_handler is called so move the call into search_binary_handler > itself to make the code simpler and easier to understand. > > Signed-off-by: "Eric W. Biederman" Yes, nice. :) I don't see any ordering dependencies here. The only thing I see is a potential for more "work done by kernel before bailing" in the sense that the arg copying will be performed before we check the kernel_read() result. I struggle to see how that might be a problem, and this get us to fewer exec.c exports. Yay! Reviewed-by: Kees Cook -- Kees Cook