Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2230769ybk; Mon, 11 May 2020 15:36:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0YHReKkqnYGuudvM094klCS9obSec035W2vaIpByqXd5hoDNMPY+ytwJ/aLLICRqkMNqH X-Received: by 2002:a17:906:2b4f:: with SMTP id b15mr5955025ejg.64.1589236582990; Mon, 11 May 2020 15:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589236582; cv=none; d=google.com; s=arc-20160816; b=otFxgNM6CxtYb3dYzKD6SnVjt7WajU3DlhClNdVOuc6kp4ner1i6uWgkxl5pKFOmrm znejt0bHek2wYyjXQuE2IdpgsKb13MgNlQu6wsBVkIsqHWaSqYGd37JlQUTrpzCBcM+m tPSXIt0vOPrn6wvJbgOjoshwyKjDsVU/lZ/BMQqFIIj3wHuakABoBtkjokCQSCQAs6r2 rER6y3IbCHi2LHAcUtHZ/LfazYRUphEDslS44TM/2W3KmODL7MqzKVJ4T5vF+d+0zaud D4QEOuSDLfa2jBxzkMGR6F5xqa6vaTYNGka51uZ/KWzn3C7yIvHtXV1XIq4CHt9R9Fcm CzCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=S2Wt9BNDW7THOxdO9pqeRaq6uvmgT980dgouD6Fq9h0=; b=udGqOnyVbGGAoChrdvIlkWHgQobd237pMSja96o2FsDGUA4NzSa7glU6/EvKgYQK1Q xZKYba0kAvumBcZ56jiqlRIAJzutgcgEqMcD27TDliy50IhULpx0kmcvuIqOAwH9Epbz CF4d8oSZGjWuajxxDKhV94Si2hWqCA2rpjwJB8Y3gzDCG9Jn1pKqxekjSuEF6V8S44zR 6fNFcru45rC837/LhUj1v+bbqS83c2lmrG6ltENgAFQm1UQOwfc1g/wUUq52UtqqUCNM 4q9Y86I5QXhj8B/8aifqhnDIdMAI6QbIKjRF9CpgByHQx48z1DthIyebCqVvPQKa+iwm jGAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="o/47o67y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si6745687eds.136.2020.05.11.15.36.00; Mon, 11 May 2020 15:36:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="o/47o67y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgEKWeG (ORCPT + 99 others); Mon, 11 May 2020 18:34:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:38578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgEKWeG (ORCPT ); Mon, 11 May 2020 18:34:06 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB9FF2070B; Mon, 11 May 2020 22:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589236445; bh=xqABZkD71yLUrEiGvEZOMQlMo99AB7+4sfIbsPXURyI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o/47o67y8/TEpiFuiovEvSiJ34a1YNDXJE2qWhAT3TOAxaIfJ8jqO2odIzQaB8nCy QYR5mUz8rFqEcTbkxTPOkcH6ijRJ5Zz/JAcGqVk02sLTbAK8ilDWr1qX8xKz+l24Qk LJ2mhKKSAwnmCXAj5xVUJeSELvBU3B9rOv6jwIPU= Date: Mon, 11 May 2020 15:34:03 -0700 From: Jakub Kicinski To: Xiaoliang Yang Cc: po.liu@nxp.com, claudiu.manoil@nxp.com, alexandru.marginean@nxp.com, vladimir.oltean@nxp.com, leoyang.li@nxp.com, mingkai.hu@nxp.com, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, davem@davemloft.net, jiri@resnulli.us, idosch@idosch.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horatiu.vultur@microchip.com, alexandre.belloni@bootlin.com, allan.nielsen@microchip.com, joergen.andreasen@microchip.com, UNGLinuxDriver@microchip.com, vinicius.gomes@intel.com, nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com, linux-devel@linux.nxdi.nxp.com Subject: Re: [PATCH v1 net-next 3/3] net: dsa: felix: add support Credit Based Shaper(CBS) for hardware offload Message-ID: <20200511153403.7b402433@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200511054332.37690-4-xiaoliang.yang_1@nxp.com> References: <20200511054332.37690-1-xiaoliang.yang_1@nxp.com> <20200511054332.37690-4-xiaoliang.yang_1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 May 2020 13:43:32 +0800 Xiaoliang Yang wrote: > +int vsc9959_qos_port_cbs_set(struct dsa_switch *ds, int port, > + struct tc_cbs_qopt_offload *cbs_qopt) static