Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: abUck11/6pQj+xk+7MnJ84tlFlTkJPO47UGAPeSQOXuc5dx+jPZhKkvO+uivaHcAoJGZAa1Yux
 3QynEL/+Jglg==
IronPort-SDR: 81qYP/AFmgS8cIV66ueeWVvmsHEvjnp+rR13xva3miR2n3QccCmQFeFrXQwuJ3JZMhOf+fj1dr
 SO18gRnaUUbA==
From:   "Brown, Aaron F" <aaron.f.brown@intel.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] igb: Report speed and duplex as unknown when device is
 runtime suspended
Thread-Topic: [PATCH v2] igb: Report speed and duplex as unknown when device
 is runtime suspended
Thread-Index: AQHWIpIDJj+i8q8yvE2ZGA3JsYZy76ijjmYA
Date:   Mon, 11 May 2020 23:14:11 +0000
Message-ID: <DM6PR11MB2890802168856F147839914FBCA10@DM6PR11MB2890.namprd11.prod.outlook.com>
References: <20200505040154.24080-1-kai.heng.feng@canonical.com>
In-Reply-To: <20200505040154.24080-1-kai.heng.feng@canonical.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 54fe4544-8ef2-4291-e0ab-08d7f60103dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 23:14:11.5392
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 78RHrRS3PaG6xXO8xRJVLEmcPDWJQ0LRV+KyT3CNbVuK2uq28Ii8fhGEIV/0AzRQ2H9I/W4wwtYinUL3eoZ4qA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3228
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Monday, May 4, 2020 9:02 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>; Brown, Aaron F
> <aaron.f.brown@intel.com>; David S. Miller <davem@davemloft.net>;
> moderated list:INTEL ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org>;
> open list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux-
> kernel@vger.kernel.org>
> Subject: [PATCH v2] igb: Report speed and duplex as unknown when device i=
s
> runtime suspended
>=20
> igb device gets runtime suspended when there's no link partner. We can't
> get correct speed under that state:
> $ cat /sys/class/net/enp3s0/speed
> 1000
>=20
> In addition to that, an error can also be spotted in dmesg:
> [  385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost
>=20
> Since device can only be runtime suspended when there's no link partner,
> we can skip reading register and let the following logic set speed and
> duplex with correct status.
>=20
> The more generic approach will be wrap get_link_ksettings() with begin()
> and complete() callbacks. However, for this particular issue, begin()
> calls igb_runtime_resume() , which tries to rtnl_lock() while the lock
> is already hold by upper ethtool layer.
>=20
> So let's take this approach until the igb_runtime_resume() no longer
> needs to hold rtnl_lock.
>=20
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Aaron Brown <aaron.f.brown@intel.com>
> Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  - Don't early return the routine so other info can be set.
>=20
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
Tested-by: Aaron Brown <aaron.f.brown@intel.com>