Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2278359ybk; Mon, 11 May 2020 17:04:18 -0700 (PDT) X-Google-Smtp-Source: APiQypJjYivpdwh9SiiE4JFd36rl3I9Bp3IM+HmOGG911Sf9kj2CTPV5zRmuZWQQF1k69hwH8poh X-Received: by 2002:a17:906:f208:: with SMTP id gt8mr16106563ejb.124.1589241858001; Mon, 11 May 2020 17:04:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589241857; cv=none; d=google.com; s=arc-20160816; b=RyTtIny33TvSxta7ALUTl9WXYO8RWksl4iQJ6HDcwVOUhd4lyq1qbYE060eup8SwfA MqkJTRK41AcUj/RacJoGfI1r9N0EGduerVmDE+45vo/TEgxP9EKM721LqCzPK9JJ3/O8 tu22JqXOGXTP5HMJmJ39RCRxFhfGRkFh/bwRnLhSV8vTeQPg8V9pWq+IINqJY+HN0zhE yZ2kGxhBS/4DyCg9qQMv6tgV1865maYPK7PxNQccBvKjHJQeL6jxbEbYh2gfMSOl/uTZ rXh2foQW6/ITfARsl/LtbMRIfnySwnfabiQicwNDw84Q5L1T574CRYEAtmCacKPM1dmo Rbfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=LmB/pA6n3Q1vz6LlwRq3k2j7+YETMnnYkIgywloLBrI=; b=PDY99Iuzfqwgi/D+YnmIFc7SJScga+3lBQQBB142MoujgoLR9CmjIc3rUYyeyzIAcu lel63kNA5fMipcaXCO5c/pGMOy1SetIjSvzge2iyC8yc82ts+W/fQsq4Yi5AKbCUlB6k QVaq3QmykPwkITQ4+2bO5T6lUKuThNUm85o6gEhprxeaOI0L2PyXkgWkxzylUAgd3UoK 5NER1bkfKMWunXUfgzHTfAiyj7lZEU4HVwKLbznCuxfVb43pVQlyRRXtPn8G+Ezoo+6y FVkRRMxWmNbr37Ry7Oa+h2qlzk2hyHPekWKunifn4ty3w4tlINcby+UFdQIUEUYov6xI tf9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy21si1168670edb.159.2020.05.11.17.03.55; Mon, 11 May 2020 17:04:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728255AbgELAAE (ORCPT + 99 others); Mon, 11 May 2020 20:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725836AbgELAAE (ORCPT ); Mon, 11 May 2020 20:00:04 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59DD8C061A0C; Mon, 11 May 2020 17:00:04 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0DDDB120ED551; Mon, 11 May 2020 17:00:04 -0700 (PDT) Date: Mon, 11 May 2020 17:00:03 -0700 (PDT) Message-Id: <20200511.170003.1583663679589394092.davem@davemloft.net> To: hch@lst.de Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: improve msg_control kernel vs user pointer handling From: David Miller In-Reply-To: <20200511115913.1420836-1-hch@lst.de> References: <20200511115913.1420836-1-hch@lst.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 May 2020 17:00:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig Date: Mon, 11 May 2020 13:59:10 +0200 > this series replace the msg_control in the kernel msghdr structure > with an anonymous union and separate fields for kernel vs user > pointers. In addition to helping a bit with type safety and reducing > sparse warnings, this also allows to remove the set_fs() in > kernel_recvmsg, helping with an eventual entire removal of set_fs(). Looks good. Things actually used to be a lot worse in the original compat code but Al Viro cleaned it up into the state it is in right now. Series applied to net-next, thanks!