Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2348993ybk; Mon, 11 May 2020 19:24:43 -0700 (PDT) X-Google-Smtp-Source: APiQypJQ7B/l8Ufe6H4MiffuSBlb5YA8mJoLJjZIL7dYKK37Y3+YcEL+YmMjobuoQx9owktyUmpe X-Received: by 2002:a17:906:3da:: with SMTP id c26mr16166337eja.290.1589250283336; Mon, 11 May 2020 19:24:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589250283; cv=none; d=google.com; s=arc-20160816; b=z69bygk3VyvALbPYbo7LD/oFFQIZU3CTl7cY7FxPaskVEs7au6H+5Ef5XOg+tcbD2g 91zwnYcYMGp+T3RO/vC08RMJ/9LfpvvCYKj7o3DBEf+FRRLfkNBjY8IMxhXgHiaU7SPK 9K4TXgYqqfSF5gq2AFCacivqQVeNtHEmhYGT/lvenqutH4DMEWz9zZqIIwL3sk94ax0G 0V2KC07s7+dl2xbKzbhyhfM/t3Eg7vaTUMPQ2w7jtZJAFdKACbk31Y7yiw6dP/d3NyNC PiiOZ4Apm/XHCD2AIspO7nbIsxVmATQ5w8JcINF6duWw2QjfeCL1GGWvN6eyzAwiLhs8 A80A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=k2YIPX12MuXHG4Ed0EuQtB9gnhkLejakrxn5AILaJgM=; b=MDeyyCvoLc9C4vIhCceDG9hWLtGPUUbHR9nd+lw8dqx8PX9JuSHYuUlOZZSvwzGtPT uiqJyOsYMe5eMIagArB5izLu+FV2BPxOthjtV4p6gbqYWKtRGpHyeXIYB6TLs6LNeE7+ XeF2oT0rtUt0Ppx9q0IFX+kXisFCP9ut8Dzp7S0YANXopK2DokKt4M1fiD3XG1zhYcAr 85OdkiuOaT3pT/kTCMOsSSFKGZmxFcVIHhfnkDjDPjTwNi503EAEd994I4dUuh8vJfKF Fc83kdYB4o+b1KsrmS4G9O/k+n0Kc/bih4fswxoanYiDDEXsTI8WE3bjpSk8IpdCzEbI e2sQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GtGpcsoc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k21si4213020edv.458.2020.05.11.19.24.20; Mon, 11 May 2020 19:24:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GtGpcsoc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbgELCUG (ORCPT + 99 others); Mon, 11 May 2020 22:20:06 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:37710 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728301AbgELCUF (ORCPT ); Mon, 11 May 2020 22:20:05 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589250005; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=k2YIPX12MuXHG4Ed0EuQtB9gnhkLejakrxn5AILaJgM=; b=GtGpcsocr7MWZoYWhISm1A/+I/SpgoVCvPBXktE34LdydoG5Gt40xMKT41EX5oFbDqZd04Zv 7qDnXO/N3ojEtzbwV/FxFRlBDWdnrGm4h1bUChc1AWhv3OuQqn/5ZiDlQL5EjD9hztgkt4SJ 3GmnFf4SL/F+lKZrkCN76m9GLQQ= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5eba07c377c5b4a9096c17d8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 12 May 2020 02:19:47 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8B23EC44788; Tue, 12 May 2020 02:19:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.8.150] (cpe-70-95-149-85.san.res.rr.com [70.95.149.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4DE55C433CB; Tue, 12 May 2020 02:19:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4DE55C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy To: Stanley Chu , linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com Cc: beanhuo@micron.com, cang@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com References: <20200509093716.21010-1-stanley.chu@mediatek.com> <20200509093716.21010-5-stanley.chu@mediatek.com> From: "Asutosh Das (asd)" Message-ID: <635f91f6-3a27-ffdd-4021-67705d4063fc@codeaurora.org> Date: Mon, 11 May 2020 19:19:42 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200509093716.21010-5-stanley.chu@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/2020 2:37 AM, Stanley Chu wrote: > Change the WriteBooster policy to keep VCC on during > runtime suspend if available WriteBooster buffer is less > than 80%. > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufs-mediatek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index 56620f7d88ce..94e97701f456 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -271,6 +271,7 @@ static int ufs_mtk_init(struct ufs_hba *hba) > > /* Enable WriteBooster */ > hba->caps |= UFSHCD_CAP_WB_EN; > + hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); > > /* > * ufshcd_vops_init() is invoked after > Patchset looks good to me. Reviewed-by: Asutosh Das -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project