Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2404660ybk; Mon, 11 May 2020 21:24:01 -0700 (PDT) X-Google-Smtp-Source: APiQypIxPjYM4UOfJL+0Q+MsyeyRdWt03bKGShcJm1okoTZHN1M62dr52FkiiGdNm6tWmndYCHF3 X-Received: by 2002:aa7:cdcb:: with SMTP id h11mr15629008edw.264.1589257441277; Mon, 11 May 2020 21:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589257441; cv=none; d=google.com; s=arc-20160816; b=a8+jEHVPxkQrRowtIdcBaJ+RpGkZ1O9gPLlFoBH4dpzgDNRaTMcliHAzEWyN3FubXj HpsGzyDXUy8L4ji4Uy7at/xsX9tOENBhNgVXFBT+Li1YSokVpoSuVFk4PH89MjRLSG9P mFO1+2huyqodT7hKt7tFCzKZCCzX12xr6DW9rceBfpOTu4CpVhFcKxvoRFygCq1LxDIH 9J4hv0NeoPoEzpyVK6EZr3S4knH5wSiYJT5xBs4eDnNwk7PjK/a1Ft/ua671G1dqeCao n5u3lbNrRuAYzthilisNI/Ty9UM75y+54QcizKN/xryGdt66qtCdz/3oebiwauZwonEO 5OFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1bpwazQ8IHBXM4k2EpHB4O7Zl6EH4Qdj3rMRXZrKLwo=; b=oX0gAwUwiQJbxCrxyD05gpudBHH3cn8HWu0lDDC1LxGR3MhoBrdwin4UfzzqA33SEr wgz232b3GUcWKyzJYhUK7MxGcJi5kjPz3LjWba3FeFI+De2o8LcdkYbAxWAtv90XF/AI Gu2wrMk5JRC2STfBGj6RXpWhpWU7bBrhcGb2r0MV/PpcJqG6cHFpNNrOqWDRIJn/0xT7 +MPKAfDRBDx7f+9gI/ItT0PTNCyxIAt2/a3wh+hdv0z9epQedJ/GTkq2lXvtocH/q8dU Q3WBR8ELgd1IqFqzFDwlnkQZRYg0wzK6EpsyHd+li92H1EzH5FrTRXGAjtkq4j9p9gWl H1tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si545158edq.592.2020.05.11.21.23.38; Mon, 11 May 2020 21:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726298AbgELEVx (ORCPT + 99 others); Tue, 12 May 2020 00:21:53 -0400 Received: from verein.lst.de ([213.95.11.211]:39074 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgELEVx (ORCPT ); Tue, 12 May 2020 00:21:53 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 28A6D68BEB; Tue, 12 May 2020 06:21:50 +0200 (CEST) Date: Tue, 12 May 2020 06:21:49 +0200 From: Christoph Hellwig To: Dimitri Sivanich Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Christoph Hellwig , "H. Peter Anvin" , Russ Anderson , Mike Travis , Steve Wahl Subject: Re: [PATCH] x86/platform/uv: HUB RTC cleanup Message-ID: <20200512042149.GA31507@lst.de> References: <20200511223535.GA23676@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511223535.GA23676@hpe.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2020 at 05:35:35PM -0500, Dimitri Sivanich wrote: > Remove unused event code and other cleanup for HUB RTC. Can you explain how this is dead? That's not entirely obvious from the patch. Also you probably want to split it the cleans into one or several additional patches and aso document them in the commit log(s). > diff --git a/arch/x86/platform/uv/uv_time.c b/arch/x86/platform/uv/uv_time.c > index 7af31b245636..1777b7164ff8 100644 > --- a/arch/x86/platform/uv/uv_time.c > +++ b/arch/x86/platform/uv/uv_time.c > @@ -1,25 +1,18 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > /* > - * SGI RTC clock/timer routines. > + * HPE RTC clock routine. Might be worth mentioning this is for the UV platform? Both the old SGI and thew new HPE are not very descriptive.