Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup
To:     Miquel Raynal <miquel.raynal@bootlin.com>
CC:     <richard@nod.at>, <vigneshr@ti.com>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <gregkh@linuxfoundation.org>,
        <boris.brezillon@collabora.com>, <linux-mtd@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <devicetree@vger.kernel.org>, <marex@denx.de>
References: <1588756279-17289-1-git-send-email-christophe.kerello@st.com>
 <1588756279-17289-5-git-send-email-christophe.kerello@st.com>
 <20200511223900.030fe5f4@xps13>
From:   Christophe Kerello <christophe.kerello@st.com>
Message-ID: <49c51a13-96a1-0241-f4d1-c5ff7d52921d@st.com>
Date:   Tue, 12 May 2020 08:49:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20200511223900.030fe5f4@xps13>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Miquel,

On 5/11/20 10:39 PM, Miquel Raynal wrote:
> 
> Christophe Kerello <christophe.kerello@st.com> wrote on Wed, 6 May 2020
> 11:11:13 +0200:
> 
>> This patch renames functions and local variables.
>> This cleanup is done to get all functions starting by stm32_fmc2_nfc
>> in the FMC2 raw NAND driver when all functions will start by
>> stm32_fmc2_ebi in the FMC2 EBI driver.
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> Applied to nand/next as well but for an unknown reason I had to do it
> by hand because the patch would not apply.
> 
> Thanks,
> Miquèl
> 
This is strange, I can apply this patch on my tree without any conflicts.
There is a compilation issue line 1301.

@@ -1302,44 +1298,45 @@ static void stm32_fmc2_write_data(struct 
nand_chip *chip, const void *buf,

  	if (force_8bit && chip->options & NAND_BUSWIDTH_16)
  		/* Reconfigure bus width to 16-bit */
-		stm32_fmc2_set_buswidth_16(fmc2, true);
+		stm32_fmc2_nfc_set_buswidth_16(nfc, true);
  }

I will rebase on top of nand/next today to check that there is no issues 
with the driver.

Regards,
Christophe Kerello.