Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2485278ybk; Tue, 12 May 2020 00:06:21 -0700 (PDT) X-Google-Smtp-Source: APiQypJ4imi/QsgrivKvxRnZ7K2mtssbjOnrpGB6m3HuXFf0Ua9w2fSU79kUlLLl94b/9XBcSygZ X-Received: by 2002:aa7:d518:: with SMTP id y24mr15900654edq.222.1589267181363; Tue, 12 May 2020 00:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589267181; cv=none; d=google.com; s=arc-20160816; b=QPF43t8/1b8/g7X+9QTx+JxPyoTGqiUMUQFgaDlYCtU25mOnd6W8fyIqMDUUqae7QU XU0sYo1tTopyQVN9scmCgsFmbxeWRF3eWJQV1ZSDGSoPNkNyQRGYUoI3SYoa7ipsg+Ji GUuikFL8dW1V+nY6SfHcD4G6BSJyIqx5Xz8vYMMJo7fInotg62E133m1DMCYhUlJ6PNW DSWj4e7FXerZaHlItLOMBw3n0RAAdmsf+DjSI51vRjFdrmkV80vOadGlU3MPe6Csgupn L9iULy/YI0+GG83o/fqQkc+9YSCurB/bocil0lNNIlYFnb9AGflNrmeMl9EOUuAy98VZ 5FpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=cPYlxJhfKmWtbP4a2dRiIg5n9Tzb/bTlK0+j+KORUjo=; b=U1MxyrCy5HF6ldwnvmWetTH/WefhPAMD1KPKQgeroG6EU1ZD4VgO83y9yTjcSW9N8d aOJ2QgvTA42c/82ffuT3PMA44tobjkACvrTrMA6PFwcFt8a/+pOiwwojn51evIw01NVN KO6Mrb7cgJiNZ4ojnHkEV7mHVTdxJAoFQLNhY76v95d6B+Asd851tvukmXWMqi+XB1Ju XAQYLPhGzd06YOihQr2bXhsuvEU1ABBjIlA/MxfffuNAfYMfRJgDJmUe2z2R+OFm6dFb m61imLpbWYYw1LzyiXK+yofgsdt7BgT97qy415cmsgzPegsSTm1hBAul5C4luSp+Hv2s ewfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fJSL2ofe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq16si6036074edb.479.2020.05.12.00.05.57; Tue, 12 May 2020 00:06:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fJSL2ofe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728980AbgELHEH (ORCPT + 99 others); Tue, 12 May 2020 03:04:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbgELHEG (ORCPT ); Tue, 12 May 2020 03:04:06 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FC0CC061A0C; Tue, 12 May 2020 00:04:06 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id a7so8960906pju.2; Tue, 12 May 2020 00:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cPYlxJhfKmWtbP4a2dRiIg5n9Tzb/bTlK0+j+KORUjo=; b=fJSL2ofei13tcbkZZb/Pr2NnHzs1Y2rSHpEwbHjNlqAa7o8IvZixYeWVN0GwMPsg3e NxAQzgeAo4o4vpJAckHUOcH80IP1TYeqpPIGlXUVpc42ex8nU7V6rEYV9TBblsrf8BEC HUIAaYhUqYBYn9phOtOrgDq3qusl55w6vxMQXl5OXAtVE1omAufTXfeTU4xVweno/ouS 68tFoeeXP1DdaqcSkvQo++6sfqHAGqbOkBYkn+s2pyoxmE1/GUPGaOX333CbZjrumHIZ +/nrG+kam+ITLvosujZ2z0x8Ewa1/gON6f49XZfUVM0/KPLnCoXNaubyBmYyyCX5Zkp0 /6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cPYlxJhfKmWtbP4a2dRiIg5n9Tzb/bTlK0+j+KORUjo=; b=cHkMnR11P86s9KNONDxf+7G4QSDyel8+3OTPhVklaFAk/Z0o7Hxz6sPIg0Bic1CoCx g1wIHryTjEl5NygS2BKKzccOhy7iOxRYDToWvf+GHmHH2xO3SQLi5v4lmQf2GGaGkGKP 2SqKkD9IuPzQ144E9OqbJM8ly4Wj0sI2/GCAy3PEnxS5YfYEb+EuolzsXBGbqMEhONZJ nvs+Ead7RXW4fxU1Rqw9G4KXht3e18yDZrzkhSXy5lBzNKCysHg0QXXZTC2P1xR76WbB f+1sKqT8fSOsivCZKs91aRms6NFPtxlxauJOqHpuuWjvwMLMgICEjOx55fywAoqtYYI4 C7lw== X-Gm-Message-State: AGi0PuYvQv82eHQ4MFZImFiTI+O5VZcCSLCklT5g6SSLDvRNTUj0NXaX s/tk5i9dfIDnPV53MeJmyZs= X-Received: by 2002:a17:902:8bc5:: with SMTP id r5mr18978437plo.218.1589267046097; Tue, 12 May 2020 00:04:06 -0700 (PDT) Received: from fmin-OptiPlex-7060.nreal.work ([103.206.190.146]) by smtp.gmail.com with ESMTPSA id 62sm11016369pfu.181.2020.05.12.00.04.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2020 00:04:05 -0700 (PDT) From: dillon.minfei@gmail.com To: robh+dt@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie, daniel@ffwll.ch, mturquette@baylibre.com, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, dillon.minfei@gmail.com Subject: [PATCH v3 4/5] clk: stm32: Fix stm32f429 ltdc driver loading hang in clk set rate. keep ltdc clk running after kernel startup Date: Tue, 12 May 2020 15:03:36 +0800 Message-Id: <1589267017-17294-5-git-send-email-dillon.minfei@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: dillon min as store stm32f4_rcc_register_pll return to the wrong offset of clks, so ltdc gate clk is null. need change clks[PLL_VCO_SAI] to clks[PLL_SAI] add CLK_IGNORE_UNUSED for ltdc to make sure clk not be freed by clk_disable_unused Signed-off-by: dillon min --- drivers/clk/clk-stm32f4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index 18117ce..0ba73de 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -129,7 +129,8 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = { { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, + { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div", + CLK_IGNORE_UNUSED }, }; static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { @@ -1757,7 +1758,7 @@ static void __init stm32f4_rcc_init(struct device_node *np) clks[PLL_VCO_I2S] = stm32f4_rcc_register_pll("vco_in", &data->pll_data[1], &stm32f4_clk_lock); - clks[PLL_VCO_SAI] = stm32f4_rcc_register_pll("vco_in", + clks[PLL_SAI] = stm32f4_rcc_register_pll("vco_in", &data->pll_data[2], &stm32f4_clk_lock); for (n = 0; n < MAX_POST_DIV; n++) { -- 2.7.4