Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2538181ybk; Tue, 12 May 2020 01:48:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvc5DHT2bCJQe/W0MgYEtpRfn0GgqzX5cIhN596ocnWI0a27AuwUBaERBQ53bckXH3zF4L X-Received: by 2002:a17:906:ce36:: with SMTP id sd22mr6877067ejb.94.1589273283247; Tue, 12 May 2020 01:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589273283; cv=none; d=google.com; s=arc-20160816; b=AbAbtrZLXB53/RJVSXV8pFNi+xAvoIvi4VyATP0uEB9exQ4tGcDtS9PVQ78QKobwBm oTJKBpHvew5XcwMybifIJBaI6/6mKIrXojmBHlKejOGV/LyzklyTHmFt35EO+FYCW5w3 V1MtR5lODEy2t0DhqsFZ/0er4CULYZzJFWE1MBNW/g3XViVXskHbxzHtCCeBEdsvsj2B +eMeKN8YDJAk/R00MJqKOWLjcff5wgrcMqUyvl7CN/Lekf6LRzD3ktdTkMPF7S3DZynl QVKCtzn32bpA9dcbvgCmBYNjbfhUTEYkMYDH2snrsCuzA5OboIYC1v9BWDoBKbtO4Cq6 Hfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=isC3Bt8lJkBAYuf3GFknhcB8WHZIk5byTcgVoEcZM5E=; b=HWabqBZ4x1/9+mgtl18mNdfGzIhR0Ql7KHTK2MBPiB6/U4faWPrNxL8bRYPSWhU6rZ 2EwfhaBut+2q3EBlSOKlge9H75CSG8zTEuPvywFyzFzA1CrSlA9xuNae432dBfJDpifC v41/WVbsViBg6KWKvfCq0Lb/JVG8Ja3QddYGE9kUF0y+B38JIPs0hbBZ/zv2PpgNrxZI 1TPWSHVQHMziurJzm24UNNnzn49idjk9SPWQ0nAH1pfgaKSs7ZhWn7NqcuOPvZl0/eK3 Prkqsfhpo6OB6eUYY0GVYGzN+moVrwyvjLgRWY75Cv+N/ZD3VlYmCVtjKM0BqrqOf1J0 gzyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si5865753ejs.38.2020.05.12.01.47.39; Tue, 12 May 2020 01:48:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729193AbgELIor (ORCPT + 99 others); Tue, 12 May 2020 04:44:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:37496 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgELIoq (ORCPT ); Tue, 12 May 2020 04:44:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A6006ABC7; Tue, 12 May 2020 08:44:46 +0000 (UTC) Date: Tue, 12 May 2020 10:44:42 +0200 From: Petr Mladek To: Kees Cook Cc: WeiXiong Liao , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Sergey Senozhatsky , Steven Rostedt , Rob Herring , Pavel Tatashin , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v7 07/18] printk: Introduce kmsg_dump_reason_str() Message-ID: <20200512084441.GD17734@linux-b0ei> References: <20200510202436.63222-1-keescook@chromium.org> <20200510202436.63222-8-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200510202436.63222-8-keescook@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2020-05-10 13:24:25, Kees Cook wrote: > The pstore subsystem already had a private version of this function. > With the coming addition of the pstore/zone driver, this needs to be > shared. As it really should live with printk, move it there instead. > > Signed-off-by: Kees Cook I looked only at this printk part and it looks good to me ;-) Acked-by: Petr Mladek Best Regards, Petr