Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <000000000000dc82ac05a55f3005@google.com> <c8f94666-3e55-2421-78c6-c2cdd0f24d16@redhat.com>
In-Reply-To: <c8f94666-3e55-2421-78c6-c2cdd0f24d16@redhat.com>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Tue, 12 May 2020 12:15:09 +0200
Message-ID: <CACT4Y+bjwR1KUkGxU9iRM+hOnMq7id5E=i84RYv41ygrv-KCEQ@mail.gmail.com>
Subject: Re: INFO: task hung in do_read_cache_page (3)
To:     Mike Christie <mchristi@redhat.com>
Cc:     syzbot <syzbot+518c54e255b5031adde4@syzkaller.appspotmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Amir Goldstein <amir73il@gmail.com>,
        Jens Axboe <axboe@kernel.dk>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        Jan Kara <jack@suse.cz>, Josef Bacik <josef@toxicpanda.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        william.kucharski@oracle.com, Matthew Wilcox <willy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 11, 2020 at 7:31 PM Mike Christie <mchristi@redhat.com> wrote:
>
> On 5/11/20 8:19 AM, syzbot wrote:
> > syzbot has bisected this bug to:
> >
> > commit 2da22da573481cc4837e246d0eee4d518b3f715e
> > Author: Mike Christie <mchristi@redhat.com>
> > Date:   Tue Aug 13 16:39:52 2019 +0000
> >
> >     nbd: fix zero cmd timeout handling v2
> >
> > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=11d6ab14100000
> > start commit:   e99332e7 gcc-10: mark more functions __init to avoid secti..
> > git tree:       upstream
> > final crash:    https://syzkaller.appspot.com/x/report.txt?x=13d6ab14100000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=15d6ab14100000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=8a96cf498e199d8b
> > dashboard link: https://syzkaller.appspot.com/bug?extid=518c54e255b5031adde4
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=146e45ec100000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=164444a4100000
> >
> > Reported-by: syzbot+518c54e255b5031adde4@syzkaller.appspotmail.com
> > Fixes: 2da22da57348 ("nbd: fix zero cmd timeout handling v2")
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> >
>
> How do you adjust/modify what is expected from the test or what is
> reported as an error?
>
> The patch added back behavior that got removed. With the patch we expect
> the hung task warnings, because we specifically want to hold onto
> running commands for longer than 120/hung_task_timeout seconds

Hi Mike,

All task hung messages are considered a kernel bug. So far this was
always true as far as I can tell. Tasks that are blocked for any
prolonged period should be killable.