Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2650483ybk; Tue, 12 May 2020 04:55:36 -0700 (PDT) X-Google-Smtp-Source: APiQypIX0Z5GN5QqMKzmYLhRWLa1BVjAxgIzOwoaoUXWFfIHSH1l1be/VyRJDZy7iWwGkZBPg7yn X-Received: by 2002:a17:906:bce6:: with SMTP id op6mr14720769ejb.337.1589284536566; Tue, 12 May 2020 04:55:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589284536; cv=none; d=google.com; s=arc-20160816; b=aLbMo1XwwCf0VPO0OfwstJyuOulf8w92YwGCv2nXLvgnbxyUoqT/mCA9Dyi111vcZu tKXWrA7us/yWmQUqsTYvU8uZ2oaFx01OEnvdRs/jrEzkT9r76FfxoM1EYpvbYM3pOY0q 54AtbLHq8DcaGBYPNJtqT1SeVK6BFugrZdhIwdgmrxKyWvliwChCibXn+Bpiyxl0U8ul yGh4/kNk3LemHUfN/aohuV+v9PoL0zVbED7DXLY234YTwWK1cdzj5piU9iiBSSidqPyC xLRUarROKZ/wNHe87OixNdBZFZdldKt6YzgAA0PiUo+BGUEbNWTqUodQiE/yBEh+F/yM OAzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QYaEkRIxIihAYt3wM9f31KOauRezATosk0Gt3w1Tu2Y=; b=oLST4pGKF8Knng9+Ip1WCXyAYKx6mbxG8TUvBUwY4/EQ5FFtbE6xcJotk6RRqsVZVj XxDhNFXFBYiIPMizsiImpObIJYvWkkt6ozStYQPkvKjAG7NRv/HSPMlEdsgeWemg+ULR oM0X2QJM/Ojr3ZVdLc/xkUJ538+v7az+MyutjQ3NOkeF9eRYK8HwhqG9aBibbQvVc9Ex D1OMpKICDCkvLTkxxpYTkfsRkw31j3rDU8qKTe5cD1DN9BXp2EzbtbLv0jo7x00kHha4 w+C9IU27SN1k0GyWseMSBcQUFVU7yQmrCOPLcsIjIqL5fRK0hKBXgfU0x70wUj81boan WFxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si8069585edy.321.2020.05.12.04.55.13; Tue, 12 May 2020 04:55:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729597AbgELLxc (ORCPT + 99 others); Tue, 12 May 2020 07:53:32 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50221 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729207AbgELLxb (ORCPT ); Tue, 12 May 2020 07:53:31 -0400 X-Originating-IP: 87.231.134.186 Received: from localhost (87-231-134-186.rev.numericable.fr [87.231.134.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 405781BF20B; Tue, 12 May 2020 11:53:29 +0000 (UTC) From: Gregory CLEMENT To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org Cc: Thomas Petazzoni , Gregory CLEMENT Subject: [PATCH v2 1/3] tty: n_gsm: Improve debug output Date: Tue, 12 May 2020 13:53:21 +0200 Message-Id: <20200512115323.1447922-2-gregory.clement@bootlin.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200512115323.1447922-1-gregory.clement@bootlin.com> References: <20200512115323.1447922-1-gregory.clement@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use appropriate print helpers for debug messages. Signed-off-by: Gregory CLEMENT --- drivers/tty/n_gsm.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index d77ed82a4840..67c8f8173023 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -504,18 +504,8 @@ static void gsm_print_packet(const char *hdr, int addr, int cr, else pr_cont("(F)"); - if (dlen) { - int ct = 0; - while (dlen--) { - if (ct % 8 == 0) { - pr_cont("\n"); - pr_debug(" "); - } - pr_cont("%02X ", *data++); - ct++; - } - } - pr_cont("\n"); + if (dlen) + print_hex_dump_bytes("", DUMP_PREFIX_NONE, data, dlen); } -- 2.26.2