Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2660637ybk; Tue, 12 May 2020 05:09:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtOKhQiKJx4t4OkuLH37D6fagsNoRNjT8O1JUoEUmIF5S8+icnLXrT3Pzp1QrZ2gGbJtIx X-Received: by 2002:a05:6402:c0f:: with SMTP id co15mr2665315edb.286.1589285368684; Tue, 12 May 2020 05:09:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589285368; cv=none; d=google.com; s=arc-20160816; b=ysaZAwEc3kQp9I9wHO0iOhr9bE6Na4Mb9bRSrOvyTR/VwYKH6gHRDvDGtygeDPRIs2 zqmo3IB4omz5ILn19sLdAQkAkxVSK5jx384RsNOXrej3jolXgdvK1AlQf1ihA5w8Asat Sx57upbV2PXBkMrr48SPRWo0N6G3/nv4jtHt/KEwzXpzVtzLwibYJMoP0D0PRH9aY/EE CAMlKw438/jBYas0/o7pMV1eBvPcVoAxGq/BjbKpQB7ax65FPWhUghbPoNqXseS2fYkk vdi+0KwBVDq4QxCt5lFJBwjZ7KYVaGOOXquHZ+Gf9qtiAvzg9+0/uw6Pi9BldQMzT9yo sqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=5btP7gtbpjtG0BhO1UsxQRV4a7bUgE/wIxxtvB4r82k=; b=XNWHzhD+P4xNaxeLQtPkwh/AaAiye9iqxpFfP2/qsVhulvhRnt4Oz1zPPRwnvrhRwd l0ONtrAOL+tIqyqMxEcMIlxriPsm4kVNoowqpSqxHuBN67PX5buHezhJIRzescvMYMtR b/ZOwOIs0NgVYbOGa4D+fdou3uI+OExvm/XHNz6ZB8ykgNCqhRr106kxKGj813Lj+Emm GyCHPX6rT9VW1hjOEYCTcDwiWAs2MyTM4vOWbAlNyNySoe4Jy8QCMURWgJXNitcAvRIj sAzGYqp7mrnKNY2uGcZrI3E/90kusKyMs6Lz87fQ2icqKyLhbm362nud+vvH7jA0maAP PeRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zc2w2MLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s23si4764100ejv.128.2020.05.12.05.09.04; Tue, 12 May 2020 05:09:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zc2w2MLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729541AbgELME7 (ORCPT + 99 others); Tue, 12 May 2020 08:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729408AbgELME6 (ORCPT ); Tue, 12 May 2020 08:04:58 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05518C061A0C for ; Tue, 12 May 2020 05:04:58 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id a21so13295824ljj.11 for ; Tue, 12 May 2020 05:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5btP7gtbpjtG0BhO1UsxQRV4a7bUgE/wIxxtvB4r82k=; b=zc2w2MLiS0a8rnKvBR7UNWYE0BbONekozXpNgUqpFZ5kVRg6+oI64tWi9lfGivgNeb 0xSZwWlbpp/ikbEom6DC9FZDRsko9yRHoXbMTuo/u1I+b77ubHC6tJbNZNCr4PyKXwUi gmbc+fu5UbWh1Bta2gBmK2Uit91iJEnEjIP+z41JS8IHO1tSoWXbs9pJm5we8/OsUBSk wJG/1Y+j7+2mqdSALCXTh6BPXPi2GTgvWnvDHTRALQ1NkXHztiY+UaKX5G+XGnAkVxzm DPKV2Wi8rW9BIu759OOt4uInwbttKSx65J3XY5GsVfHXBlSahmJuIO2atCuXwtGbg85G EaUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5btP7gtbpjtG0BhO1UsxQRV4a7bUgE/wIxxtvB4r82k=; b=MaFDKCDta4sEHGNI3CpfSf1JaEFvq7XTGos07XM6f2gEdUFktGE/l4BO7w3XYHqePW SFeJp8RHHVz999wr0JXc0Zz4mG5VieQ4hZpOO5IybFHiHRq2DTwjSpnQYpGRCMkb/aym LhmLHIOr1yaAc4awrI8Y22KSxG97aMtRV+l+78JwQ+n4iDy4jlCySGarTV6tszgMJCr6 OfFPZUl7mfoKdmhtpex6ucSlUi18oModXqzxg9LpNfduecAYe7Jjy/t0vnd28KAPP/Is t9nGTJvpIpWubSbJ4LZqb3yHmdFpUtDl3tySLADaJ3EdCpBPVlbNvh/93tml+x2JuJvH V70A== X-Gm-Message-State: AOAM530+9BT048qlxbqVMMtJJSf8OJ8vw+3Eq51tGFAIwreQX7pQ5Q28 MNaAM5jkdaKrJvlpg5qyIvRCy7MGWnqfugswR9fj+Q== X-Received: by 2002:a05:651c:32e:: with SMTP id b14mr13584425ljp.277.1589285096459; Tue, 12 May 2020 05:04:56 -0700 (PDT) MIME-Version: 1.0 References: <20200428141459.87624-1-weiyongjun1@huawei.com> <20200430073145.52321-1-weiyongjun1@huawei.com> In-Reply-To: <20200430073145.52321-1-weiyongjun1@huawei.com> From: Linus Walleij Date: Tue, 12 May 2020 14:04:45 +0200 Message-ID: Subject: Re: [PATCH -next v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind() To: Wei Yongjun Cc: David Airlie , Daniel Vetter , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 9:30 AM Wei Yongjun wrote: > The of_drm_find_bridge() function returns NULL on error, it doesn't return > error pointers so this check doesn't work. > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Wei Yongjun > --- > v1 - > v2: add fixes and fix the subject Already applied v1, no big deal anyways, its a nonurgent fix. Yours, Linus Walleij