Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2703326ybk; Tue, 12 May 2020 06:12:01 -0700 (PDT) X-Google-Smtp-Source: APiQypJx1ZRPB20zwNE61NeczliE/jplwkMQ5Jn1o3Dh7i12kpZQzVHnIdUbcJrTY+I5JQHqOb2O X-Received: by 2002:aa7:dbc3:: with SMTP id v3mr10031538edt.103.1589289121241; Tue, 12 May 2020 06:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589289121; cv=none; d=google.com; s=arc-20160816; b=cFNuLivTzUgdtkxy4wBrk6ejTj0UIUX2RFY+MDngpB/ABdvzqFWMLNS1ILkVFfME9h eGqmlbyrYm0VgAFTgYyC5IsaE6USlScPfqkmeMhN8jNGaKUnlTsfg9PiycJosp+m0iBd OqXzkanrFg2yiz6YcBzHpGVKPukjYnaR3rVRK3Pv6WjFOQj/ekOJ2JpaAYXC/SUrFpOf 8laKMs3eh+i27b6BsYTu7q5Nty6LqE6WZf25WFlMNVux0BdBh3YE6YwyOnFXIiZ4lQmB 61QeyG9XzZtsdNUKlJEgw6xxPJJGDXab1u3P+mcE3xOh4q04GoADlCX6qSdz46csUvp7 LJWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=EgYlYjw5XDmplMPW5m1uxbfuC1qmkJzFLKLYFtxuYZ8=; b=GrweX3/Yl4/JdaDa0kJM762HQG0o7FOww9m2xXPI2igg0KmF6ljmiPa0n4yz/jpw/J rY1PQeunigAZ+z8iO+203IYLUZc0v7gKsoW2op8pDu02ZUrWVEMBPztoeccPN8la2mmD vJQ63mvGI9wA2rc404lXSOKgLtI5bNFueY2hzohkPC5w8Oeq0gq4wEh5TJuMp8MdtUKo lT2GntxKSylbvqOMWUKnmRL+TpI6MIYkcRtftZSRi0BCtOUMhc55I5NHYOimblcoV4n3 0fq/NWInFll0Czj2OYg9pgmspMGtboCyyRbIJlBKIxMKVwy8SELiulmLTOZ7wTX/46QX AC1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a42si8015997edf.186.2020.05.12.06.11.37; Tue, 12 May 2020 06:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729626AbgELNJk (ORCPT + 99 others); Tue, 12 May 2020 09:09:40 -0400 Received: from verein.lst.de ([213.95.11.211]:41138 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727783AbgELNJj (ORCPT ); Tue, 12 May 2020 09:09:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6FB5F68BEB; Tue, 12 May 2020 15:09:36 +0200 (CEST) Date: Tue, 12 May 2020 15:09:36 +0200 From: Christoph Hellwig To: Marek Szyprowski Cc: Christoph Hellwig , dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Robin Murphy , Bartlomiej Zolnierkiewicz , linux-arm-kernel@lists.infradead.org, David Airlie , Daniel Vetter Subject: Re: [PATCH v4 01/38] dma-mapping: add generic helpers for mapping sgtable objects Message-ID: <20200512130936.GA24428@lst.de> References: <20200512085710.14688-1-m.szyprowski@samsung.com> <20200512090058.14910-1-m.szyprowski@samsung.com> <20200512121808.GA20393@lst.de> <1a80255d-81de-2c5d-6d06-ea126fd7f994@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a80255d-81de-2c5d-6d06-ea126fd7f994@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2020 at 03:00:31PM +0200, Marek Szyprowski wrote: > > if (n <= 0) > > return -EINVAL; > > sgt->nents = n; > > return 0; > > > Indeed this version looks much better. I will resend it in a few minutes. I could also just fix it up when applying the patch.