Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Tue, 12 May 2020 10:27:37 -0300
To:     Sandipan Das <sandipan@linux.ibm.com>
Cc:     Ravi Bangoria <ravi.bangoria@linux.ibm.com>, leo.yan@linaro.org,
        jolsa@kernel.org, naveen.n.rao@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
Message-ID: <20200512132737.GH28888@kernel.org>
References: <20200509112113.174745-1-ravi.bangoria@linux.ibm.com>
 <88066ce0-f586-b88d-75b5-2706684818d7@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <88066ce0-f586-b88d-75b5-2706684818d7@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
> 
> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > removed powerpc specific sym-handling.c file from Build. This wasn't
> > caught by build CI because all functions in this file are declared
> > as __weak in common code. Fix it.
> > 
> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > Reported-by: Sandipan Das <sandipan@linux.ibm.com>
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> > ---
> >  tools/perf/arch/powerpc/util/Build | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> > index e5c9504f8586..e86e210bf514 100644
> > --- a/tools/perf/arch/powerpc/util/Build
> > +++ b/tools/perf/arch/powerpc/util/Build
> > @@ -2,6 +2,7 @@ perf-y += header.o
> >  perf-y += kvm-stat.o
> >  perf-y += perf_regs.o
> >  perf-y += mem-events.o
> > +perf-y += sym-handling.o
> >  
> >  perf-$(CONFIG_DWARF) += dwarf-regs.o
> >  perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> > 
> 
> Thanks for fixing this!
> 
> Acked-by: Sandipan Das <sandipan@linux.ibm.com>

Leo, Naveen, can you comment on this?

- Arnaldo