Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 May 2020 10:41:14 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [for-linus][PATCH 3/3] bootconfig: Fix to prevent warning
 message if no bootconfig option
Message-ID: <20200512104114.5f70803a@gandalf.local.home>
In-Reply-To: <0686d98b-5eba-b761-6d84-f93edfbbb5a6@molgen.mpg.de>
References: <20200512132317.343672858@goodmis.org>
        <20200512132348.029291894@goodmis.org>
        <0686d98b-5eba-b761-6d84-f93edfbbb5a6@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 12 May 2020 16:36:53 +0200
Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> Dear Steven,
> 
> 
> Am 12.05.20 um 15:23 schrieb Steven Rostedt:
> > From: Masami Hiramatsu <mhiramat@kernel.org>
> > 
> > Commit de462e5f1071 ("bootconfig: Fix to remove bootconfig
> > data from initrd while boot") causes a cosmetic regression
> > on dmesg, which warns "no bootconfig data" message without
> > bootconfig cmdline option.
> > 
> > Fix setup_boot_config() by moving no bootconfig check after
> > commandline option check.
> > 
> > Link: http://lkml.kernel.org/r/9b1ba335-071d-c983-89a4-2677b522dcc8@molgen.mpg.de
> > Link: http://lkml.kernel.org/r/158916116468.21787.14558782332170588206.stgit@devnote2  
> 
> It’d be great if you could update your script to include HTTPS URLs. 
> That would save one redirect.

Never thought of that as an issue, but sure, it's easy enough to fix.

> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>

Thanks,

-- Steve