Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: U+iNjUbmpDCp9F9k2UfTFphu4TAsibtjWIiKHTEiYdAW8kw3jEKC0u3s1vxHdZOB9tXfrOHfZt
 MlvuekVncwtg==
IronPort-SDR: nbIPwbVM1FtOkmdF1YvWu67mvfPrzxseWx7VxXKXCiGVUa0QnxqzBkn/Wf3aF1q6kFrtsGuiva
 AjQFJRAdYRgQ==
Subject: Re: [PATCH 3/3] soundwire: bus_type: add sdw_master_device support
To:     Vinod Koul <vkoul@kernel.org>
Cc:     alsa-devel@alsa-project.org, tiwai@suse.de,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
        broonie@kernel.org, srinivas.kandagatla@linaro.org,
        jank@cadence.com, mengdong.lin@intel.com,
        slawomir.blauciak@intel.com, sanyog.r.kale@intel.com,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        rander.wang@linux.intel.com, bard.liao@intel.com
References: <20200429185145.12891-1-yung-chuan.liao@linux.intel.com>
 <20200429185145.12891-4-yung-chuan.liao@linux.intel.com>
 <20200511063227.GS1375924@vkoul-mobl>
 <e214d308-1b92-a7a5-3c76-da05dca99cc5@linux.intel.com>
 <20200512033035.GV1375924@vkoul-mobl>
 <84f09843-3245-5fa4-530f-c915b28e9bc5@linux.intel.com>
 <20200512155927.GA4297@vkoul-mobl>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <79ee2b4a-c2e3-aba7-8b67-b1a01922d089@linux.intel.com>
Date:   Tue, 12 May 2020 11:08:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200512155927.GA4297@vkoul-mobl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/12/20 10:59 AM, Vinod Koul wrote:
> On 12-05-20, 09:36, Pierre-Louis Bossart wrote:
>> On 5/11/20 10:30 PM, Vinod Koul wrote:
>>> On 11-05-20, 14:00, Pierre-Louis Bossart wrote:
>>>>>> +	md = &bus->md;
>>>>>> +	md->dev.bus = &sdw_bus_type;
>>>>>> +	md->dev.type = &sdw_master_type;
>>>>>> +	md->dev.parent = parent;
>>>>>> +	md->dev.of_node = parent->of_node;
>>>>>> +	md->dev.fwnode = fwnode;
>>>>>> +	md->dev.dma_mask = parent->dma_mask;
>>>>>> +
>>>>>> +	dev_set_name(&md->dev, "sdw-master-%d", bus->link_id);
>>>>>
>>>>> This give nice sdw-master-0. In DT this comes from reg property. I dont
>>>>> seem to recall if the ACPI/Disco spec treats link_id as unique across
>>>>> the system, can you check that please, if not we would need to update
>>>>> this.
>>>> Table 3 in the Disco for Soundwire 1.0 spec: "all LinkID values are relative
>>>> to the immediate parent Device."
>>>>
>>>> There isn't any known implementation with more than one controller.
>>>
>>> But then it can come in "future" right. So lets try to make it future
>>> proof by not using the link_id (we can expose that as a sysfs if people
>>> want to know). So a global unique id needs to allocated (hint: idr or
>>> equivalent) and used as master_id
>>
>> Can you clarify if you are asking for a global ID for Intel/ACPI platforms,
>> or for DT as well? I can't figure out from the soundwire-controller.yaml
>> definitions if there is already a notion of unique ID.
> 
> If ACPI was unique, then I was planning to update the definition below
> to include that. Given that it is not the case, let's make it agnostic to
> underlying firmware.

I am not sure I understand how this would be done.

The call sequence is

sdw_bus_master_add(bus)
     sdw_master_device_add(bus, parent, fw_node)

At the bus level, we don't have any information on which controller the 
bus is related to.

We'd need to add an argument to sdw_bus_master_add() and have the 
controller unique ID be allocated outside of the SoundWire core, hence 
my question on whether the DT definition should not be extended.

> 
>>
>> properties:
>>    $nodename:
>>      pattern: "^soundwire(@.*)?$"
>>
>>     soundwire@c2d0000 {
>>          #address-cells = <2>;
>>          #size-cells = <0>;
>>          reg = <0x0c2d0000 0x2000>;
>