Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2858908ybk; Tue, 12 May 2020 09:47:53 -0700 (PDT) X-Google-Smtp-Source: APiQypKrMOzosqMRqTIk3+tBhug1e7bUXaGT0EReI6hdOfh7M519oZj9FqtpNDAPRwkPR/AiJSGT X-Received: by 2002:a17:906:1443:: with SMTP id q3mr19047952ejc.325.1589302073149; Tue, 12 May 2020 09:47:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589302073; cv=none; d=google.com; s=arc-20160816; b=dOgV6rIrmLwkiMAa6YrrSYnzt/tEeiETH3zXc7ai6uZQst1FRYmWLQYdzFFqNdoga6 Xc0nmEU6jREOJkEfKyaYmGBp1Md78kBbAKyGafAQ59tbrDlDSBDOuAmFfcQNgDcpX0DI t4toKI9nY8qQKynI4svewaemSeVnskAIPQyqx/TD9dTl85yZz2UJnXhPP/mMVpwjEwWC w03cbWlXt1Lq0CRIqHNTL8PUyEvTqRwxEfAxkMPP5UsovO7QmYjFL3MK7xA0sg3X7/J6 ct8S9enP5GWefDJPtidhB2+Z9fuh3V2B16SedZsEh6ZJQZCuf3sUV8M1fksZ+IfhTwbp j6QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:subject:references:in-reply-to :cc:to:from:date:dkim-signature; bh=KCBWp8XhfyVvib9I4zjJjodj9AJpRlD7g3WMzkoUBCs=; b=KAS8jTsh0ae5lrFkyCh4q8VilkV8qcupztCuqvFsQBrlhUxxLqNuSjvPmnFamD/pTP NENIAbwaM/9e8JMUUFBRfWS6D4Xd2VS7NTC44JkUOBIJpJWvnydgZG5Z4YtLvizA0Rss Gzl4/yOjqRTBASONPhOYK1j/5jmqeb6t7c61n2qUsXZTXKCIMaoivRjfCLIw2KX84yag AVuaY8GxyMnHlsO8nqqpm6LuP8ONst1pK59u5OXeY39WI65yLslPB7q3nTsdjSktc4mk AXXYQr+56DhlGedyyltRWcC5fFnevoWtw4dftSbf61Nqy1GgjWX+KyuxPj9InO8M79DK Mv3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NSaEkz8h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pv24si8239132ejb.244.2020.05.12.09.47.24; Tue, 12 May 2020 09:47:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NSaEkz8h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgELQpR (ORCPT + 99 others); Tue, 12 May 2020 12:45:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:42224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgELQpR (ORCPT ); Tue, 12 May 2020 12:45:17 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62A0C20714; Tue, 12 May 2020 16:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589301916; bh=PoU1PDlU8EtoqlFaKH81yByCt0mWPcBR7YxQuQ0TaeM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=NSaEkz8h2XIJ8DYvcW+GtWUn+dfGp8KHikaeRgwfWw+GuNqwXRCGo6uvX1n1qdaqj aYvwlYOaCdchKoByZK89nXSFA9Wi7EWCZlE5VFn2ZNoopKxEtc22z07QIf+mzobT+t x8doeUp+oESQWVCEq76ZJzNwrZT0rFcvBzelPO+s= Date: Tue, 12 May 2020 17:45:14 +0100 From: Mark Brown To: Christophe JAILLET , lgirdwood@gmail.com, linux-omap@vger.kernel.org, perex@perex.cz, tiwai@suse.com, jarkko.nikula@bitmer.com, peter.ujfalusi@ti.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <20200512134325.252073-1-christophe.jaillet@wanadoo.fr> References: <20200512134325.252073-1-christophe.jaillet@wanadoo.fr> Subject: Re: [PATCH] ASoC: ti: omap-mcbsp: Fix an error handling path in 'asoc_mcbsp_probe()' Message-Id: <158930188456.55827.1765769472470838223.b4-ty@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 May 2020 15:43:25 +0200, Christophe JAILLET wrote: > If an error occurs after the call to 'omap_mcbsp_init()', the reference to > 'mcbsp->fclk' must be decremented, as already done in the remove function. > > This can be achieved easily by using the devm_ variant of 'clk_get()' > when the reference is taken in 'omap_mcbsp_init()' > > This fixes the leak in the probe and has the side effect to simplify both > the error handling path of 'omap_mcbsp_init()' and the remove function. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/1] ASoC: ti: omap-mcbsp: Fix an error handling path in 'asoc_mcbsp_probe()' commit: 03990fd58d2b7c8f7d53e514ba9b8749fac260f9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark