Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2899447ybk; Tue, 12 May 2020 10:48:26 -0700 (PDT) X-Google-Smtp-Source: APiQypIWjjPsmV4BFoCk0tbsFezaRGqnoCGSDpMqja1tLf3DUlA8jMHOePnMhzmG0Hco/WJxH2cB X-Received: by 2002:a17:906:6a48:: with SMTP id n8mr18198181ejs.315.1589305705873; Tue, 12 May 2020 10:48:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589305705; cv=none; d=google.com; s=arc-20160816; b=hvSjm3YE/jQMgY0c0P76slt9GfKX7DkpHce76y9ZO4U+0HQa1dJ4r/avHWHNLSqPGQ zZgbuHyvPqCVhxTKLVJq67pPJ8Q8OP9+Ac6wtodLOx4LaghOSP66gE274ZLax/DzW6d0 H2RAGYQgQhFfR8CXcA59QYoCOJcYRg6GOQg3vIMJX+cVc8AzWU7ls4cU63TzW0GrSB/f 5Rd4eXF/pZ4ObWzn9XHtmkkGoEhGryAWFf5dax2Eobj8Qjlrlx8jp3nNQpR6iXgmkuTX oL2M4HLTwbI8egIxZ/Cp/ZgH5NnPdIUfw22pavqj6I1VezQ90cuk358GZhy4h0xtpqC4 00hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from; bh=Y8ds+JpuZe2pIYioFBK2teyRiXpVGM4Vjzbullr12fA=; b=Hs7uHsOkKgk39cNLIM0qhY/LfswfVu9zhXNP+sS4avam0u/qxsp9gcguS6lBZsbjDz 6sWSEhQSkMxH6L4kD0lheDP30kw0ksJ/6S8UkPbQQTFK+rVmPjLiyKUG4iq/m76BxuZJ u+OpnyeNjutNaNe7lPu8PJS/YJxKI0W+inOvFdKBsn3S+GqUSroom2Z61Oyizc6MOBV3 +LH08olIadvRJdkWRAH2JvQ+GeMqG/CaHVe/RaNlopemcn3AWyaiDcadrbeQYfo/3GYp xs229aryxI9qPsFDDTVCP+iZ65vl+dkuxVFdRw8+E6GOaZHnJ/QToAZx+6fzmV0gcQYi iqHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm14si7469508edb.546.2020.05.12.10.48.02; Tue, 12 May 2020 10:48:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728258AbgELRoh (ORCPT + 99 others); Tue, 12 May 2020 13:44:37 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:42680 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgELRoh (ORCPT ); Tue, 12 May 2020 13:44:37 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYYxA-0006HM-VP; Tue, 12 May 2020 11:44:28 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jYYxA-0006YR-5x; Tue, 12 May 2020 11:44:28 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Luis Chamberlain Cc: Xiaoming Ni , Al Viro , Kees Cook , Stephen Rothwell , Helge Deller , Parisc List , yzaikin@google.com, linux-fsdevel@vger.kernel.org, Linux Next Mailing List , Linux Kernel Mailing List , Christoph Hellwig References: <20200511111123.68ccbaa3@canb.auug.org.au> <99095805-8cbe-d140-e2f1-0c5a3e84d7e7@huawei.com> <20200512003305.GX11244@42.do-not-panic.com> <87y2pxs73w.fsf@x220.int.ebiederm.org> <20200512172413.GC11244@42.do-not-panic.com> Date: Tue, 12 May 2020 12:40:55 -0500 In-Reply-To: <20200512172413.GC11244@42.do-not-panic.com> (Luis Chamberlain's message of "Tue, 12 May 2020 17:24:13 +0000") Message-ID: <87k11hrqzc.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jYYxA-0006YR-5x;;;mid=<87k11hrqzc.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18BZ+GM7YxDSNtI/wYtLPC80aezvVDUzig= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,XMSubLong,XMSubMetaSx_00 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4999] * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 0; Body=1 Fuz1=1 Fuz2=1] * 1.0 XMSubMetaSx_00 1+ Sexy Words X-Spam-DCC: ; sa06 0; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Luis Chamberlain X-Spam-Relay-Country: X-Spam-Timing: total 297 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 10 (3.3%), b_tie_ro: 9 (2.9%), parse: 0.80 (0.3%), extract_message_metadata: 2.6 (0.9%), get_uri_detail_list: 0.80 (0.3%), tests_pri_-1000: 3.8 (1.3%), tests_pri_-950: 1.33 (0.4%), tests_pri_-900: 1.00 (0.3%), tests_pri_-90: 94 (31.7%), check_bayes: 93 (31.2%), b_tokenize: 6 (1.9%), b_tok_get_all: 6 (1.9%), b_comp_prob: 1.98 (0.7%), b_tok_touch_all: 76 (25.6%), b_finish: 0.90 (0.3%), tests_pri_0: 167 (56.1%), check_dkim_signature: 0.53 (0.2%), check_dkim_adsp: 2.8 (1.0%), poll_dns_idle: 0.75 (0.3%), tests_pri_10: 2.2 (0.8%), tests_pri_500: 7 (2.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: linux-next: manual merge of the vfs tree with the parisc-hd tree X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luis Chamberlain writes: > On Tue, May 12, 2020 at 06:52:35AM -0500, Eric W. Biederman wrote: >> Luis Chamberlain writes: >> >> > +static struct ctl_table fs_base_table[] = { >> > + { >> > + .procname = "fs", >> > + .mode = 0555, >> > + .child = fs_table, >> > + }, >> > + { } >> > +}; >> ^^^^^^^^^^^^^^^^^^^^^^^^ You don't need this at all. >> > > +static int __init fs_procsys_init(void) >> > +{ >> > + struct ctl_table_header *hdr; >> > + >> > + hdr = register_sysctl_table(fs_base_table); >> ^^^^^^^^^^^^^^^^^^^^^ Please use register_sysctl instead. >> AKA >> hdr = register_sysctl("fs", fs_table); > > Ah, much cleaner thanks! It is my hope you we can get rid of register_sysctl_table one of these days. It was the original interface but today it is just a compatibility wrapper. I unfortunately ran out of steam last time before I finished converting everything over. Eric