Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751750AbWCMB0y (ORCPT ); Sun, 12 Mar 2006 20:26:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751853AbWCMB0y (ORCPT ); Sun, 12 Mar 2006 20:26:54 -0500 Received: from mail2.genealogia.fi ([194.100.116.229]:18050 "EHLO mail2.genealogia.fi") by vger.kernel.org with ESMTP id S1751603AbWCMB0x (ORCPT ); Sun, 12 Mar 2006 20:26:53 -0500 Date: Sun, 12 Mar 2006 17:23:41 -0800 From: Jouni Malinen To: Adrian Bunk Cc: hostap@shmoo.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] hostap_ap.c:hostap_add_sta(): inconsequent NULL checking Message-ID: <20060313012341.GV9383@jm.kir.nu> Mail-Followup-To: Adrian Bunk , hostap@shmoo.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20060310191026.GS21864@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060310191026.GS21864@stusta.de> User-Agent: Mutt/1.5.11 X-Spam-Score: -2.6 (--) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 14 On Fri, Mar 10, 2006 at 08:10:26PM +0100, Adrian Bunk wrote: > The Coverity checker spotted this inconsequent NULL checking > (unconditionally dereferencing directly after checking for NULL > isn't a good idea). Thanks! Added to my queue for wireless-2.6. -- Jouni Malinen PGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/