Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200428172322.1.I396f351e364f3c09df7c7606e79abefb8682c092@changeid>
 <20200428172322.2.Iacb3c8152c3cf9015a91308678155a578b0cc050@changeid> <a23b7a97f349e6f74b993a4e127564ad3f7d6929.camel@perches.com>
In-Reply-To: <a23b7a97f349e6f74b993a4e127564ad3f7d6929.camel@perches.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 13 May 2020 00:09:07 +0300
Message-ID: <CAHp75VewDvjDJjvKgQ_5v_=Kxp6B1js0J+PrsfP-WC+qa=ogtQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned"
To:     Joe Perches <joe@perches.com>
Cc:     Douglas Anderson <dianders@chromium.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 3:40 AM Joe Perches <joe@perches.com> wrote:
> On Tue, 2020-04-28 at 17:23 -0700, Douglas Anderson wrote:

...

> +       int     (*request)(struct gpio_chip *gc, unsigned int offset);
> +       void    (*free)(struct gpio_chip *gc, unsigned int offset);
> +       int     (*get_direction)(struct gpio_chip *gc, unsigned int offset);
> +       int     (*direction_input)(struct gpio_chip *gc, unsigned int offset);
> +       int     (*direction_output)(struct gpio_chip *gc,
> +                                   unsigned int offset, int value);

Here...

> +       int     (*get)(struct gpio_chip *gc, unsigned int offset);
> +       int     (*get_multiple)(struct gpio_chip *gc,
> +                               unsigned long *mask, unsigned long *bits);
> +       void    (*set)(struct gpio_chip *gc, unsigned int offset, int value);
> +       void    (*set_multiple)(struct gpio_chip *gc,
> +                               unsigned long *mask, unsigned long *bits);
> +       int     (*set_config)(struct gpio_chip *gc,
> +                             unsigned int offset, unsigned long config);

...and here perhaps offset to move to previous line despite checkpatch warnings.

> +       int     (*to_irq)(struct gpio_chip *gc, unsigned int offset);
> +       void    (*dbg_show)(struct seq_file *s, struct gpio_chip *gc);
> +       int     (*init_valid_mask)(struct gpio_chip *gc,
> +                                  unsigned long *valid_mask,
> +                                  unsigned int ngpios);
> +       int     (*add_pin_ranges)(struct gpio_chip *gc);

-- 
With Best Regards,
Andy Shevchenko