Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anson Huang <anson.huang@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     "rui.zhang@intel.com" <rui.zhang@intel.com>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        "amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
Thread-Topic: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
Thread-Index: AQHWDtWuHhuFKGSv1ECuhQdSmjVzK6iCZy4AgAFNxdCAIhNSMA==
Date:   Wed, 13 May 2020 06:55:34 +0000
Message-ID: <DB3PR0402MB39167476CE5FA107505A78C5F5BF0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
References: <1586480844-19227-1-git-send-email-Anson.Huang@nxp.com>
 <20200420183512.GA5483@bogus>
 <DB3PR0402MB3916B60832507A72F39750EAF5D50@DB3PR0402MB3916.eurprd04.prod.outlook.com>
In-Reply-To: <DB3PR0402MB3916B60832507A72F39750EAF5D50@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e591871a-57d0-427b-c039-08d7f70aa2ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 06:55:35.0464
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FZNozB8sYIG2UzAi6yIQ3dYvBNBmddacCaP9p+Lab+NuAnFRUBG/OqCiRPOyAA2u81jhqvjQ9P0KdwiZFjFkhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3769
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Rob

> Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
>=20
> Hi, Rob
>=20
>=20
> > Subject: Re: [PATCH V2] dt-bindings: thermal: Convert i.MX to
> > json-schema
> >
> > On Fri, Apr 10, 2020 at 09:07:24AM +0800, Anson Huang wrote:
> > > Convert the i.MX thermal binding to DT schema format using
> > > json-schema
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > Changes since V1:
> > > 	- make clock property optional.
> > > ---
> > >  .../devicetree/bindings/thermal/imx-thermal.txt    | 61 ------------=
--
> > >  .../devicetree/bindings/thermal/imx-thermal.yaml   | 96
> > ++++++++++++++++++++++
> > >  2 files changed, 96 insertions(+), 61 deletions(-)  delete mode
> > > 100644 Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > >  create mode 100644
> > > Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > > b/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > > deleted file mode 100644
> > > index 823e417..0000000
> > > +
> > > +title: NXP i.MX Thermal Binding
> > > +
> > > +maintainers:
> > > +  - Anson Huang <Anson.Huang@nxp.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - fsl,imx6q-tempmon
> > > +              - fsl,imx6sx-tempmon
> > > +              - fsl,imx7d-tempmon
> > > +
> > > +  interrupts:
> > > +    description: |
> > > +      The interrupt output of the controller, the IRQ will be trigge=
red
> > > +      when temperature is higher than high threshold.
> > > +    maxItems: 1
> > > +
> > > +  nvmem-cells:
> > > +    description: |
> > > +      Phandle to the calibration cells provided by ocotp for calibra=
tion
> > > +      data and temperature grade.
> > > +    maxItems: 2
> > > +
> > > +  nvmem-cell-names:
> > > +    maxItems: 2
> > > +    items:
> > > +      - const: calib
> > > +      - const: temp_grade
> > > +
> > > +  fsl,tempmon:
> > > +    $ref: '/schemas/types.yaml#/definitions/phandle'
> > > +    description: |
> > > +      Phandle pointer to system controller that contains TEMPMON
> > control
> > > +      registers, e.g. ANATOP on imx6q.
> >
> > Really, this should have been a child of the system controller. Not
> > too late to do that, but you'd need to keep this for compatibility.
>=20
> Sorry, I don't quite get your point, can you provide more details or exam=
ple,
> thanks.

I guess you meant the tempmon node should be put inside anatop node? Then
DT files also needs to be changed? Right?=20

 anatop: anatop@20c8000 {
         compatible =3D "fsl,imx6sx-anatop", "fsl,imx6q-anatop",
         "syscon", "simple-mfd";
         reg =3D <0x020c8000 0x1000>;
         interrupts =3D <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
                   <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
                   <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
 ...
 };

 tempmon: tempmon {
         compatible =3D "fsl,imx6sx-tempmon", "fsl,imx6q-tempmon";
         interrupt-parent =3D <&gpc>;
         interrupts =3D <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
         fsl,tempmon =3D <&anatop>;
         nvmem-cells =3D <&tempmon_calib>, <&tempmon_temp_grade>;
         nvmem-cell-names =3D "calib", "temp_grade";
         clocks =3D <&clks IMX6SX_CLK_PLL3_USB_OTG>;
  };

Thanks,
Anson