Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200512204543.22090-1-robh@kernel.org> <20200512204543.22090-5-robh@kernel.org>
In-Reply-To: <20200512204543.22090-5-robh@kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 13 May 2020 09:04:28 +0200
Message-ID: <CAMuHMdWoh94eFvVKHt5si3LOX4Nwx0-JssxVOy=fXPMXxgndXg@mail.gmail.com>
Subject: Re: [PATCH 5/5] dt-bindings: Fix incorrect 'reg' property sizes
To:     Rob Herring <robh@kernel.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,

On Tue, May 12, 2020 at 10:46 PM Rob Herring <robh@kernel.org> wrote:
> The examples template is a 'simple-bus' with a size of 1 cell for
> #address-cells and #size-cells. The schema was only checking the entries
> had between 2 and 4 cells which really only errors on I2C or SPI type
> devices with a single cell.
>
> The easiest fix in most cases is to change the 'reg' property to for 1 cell
> address and size. In some cases with child devices having 2 cells, that
> doesn't make sense so a bus node is needed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

>  .../devicetree/bindings/arm/renesas,prr.yaml  |  2 +-
>  .../bindings/display/renesas,cmm.yaml         |  2 +-
>  .../interrupt-controller/renesas,irqc.yaml    |  2 +-
>  .../bindings/media/renesas,csi2.yaml          |  2 +-
>  .../bindings/media/renesas,vin.yaml           |  6 +-
>  .../bindings/net/renesas,ether.yaml           |  2 +-
>  .../bindings/pwm/renesas,pwm-rcar.yaml        |  2 +-
>  .../bindings/spi/renesas,sh-msiof.yaml        |  2 +-
>  .../bindings/thermal/rcar-thermal.yaml        |  6 +-
>  .../bindings/usb/renesas,usb3-peri.yaml       |  2 +-
>  .../bindings/usb/renesas,usbhs.yaml           |  2 +-

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds