Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp314198ybk;
        Wed, 13 May 2020 00:31:27 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzORCzLoM3Fzf93/ogWKJVCmjaI/oL8D9Zeg0CG0zmdz66ooWPbeP2QzncP8I6Avyk9D5IL
X-Received: by 2002:aa7:dc49:: with SMTP id g9mr9657733edu.62.1589355087629;
        Wed, 13 May 2020 00:31:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1589355087; cv=none;
        d=google.com; s=arc-20160816;
        b=x3h0zsffUOIx27apJrIbiARONnGm2ZY9ybe8f3MHoBkVCOeveMbvdehRtJSj6Bk4GT
         iDWyuWS4ekuxlz6Y7jqCYEnotYo6KJmG39FlGYnCnc518eHj+6j2T9McdciwjAAkR9eQ
         bP5cDqFd65duTa0TsvGj721EIpPmj0rw2Hg+nDednhiTac/fAkfKOaX3zLpRjBP5BPhs
         h03H/Pin8Nst+HUuNy9EbJPo2OJsYiyqM8Tc0qTcNFzh3P3Mp9XzE41jowB5/09OIFpa
         e42+QHiM05mGedDoYNb5jnPixVOn6C1DC6kXrFnFirRTPnr8glAy17OQhwjJ2LyMlrY3
         0OBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=efIjqqDseHcH1vD6O3AWpKgWaJ3/GNtR1qm3aKhhfa0=;
        b=aBetuG49P1224Hxme0G4qpz4xw8XGXkyhSsikD/tXzW1fDiMxtgJSNSx/b4DuSOL6v
         SCYRPzqMUepFjPuxs90GgPFuzAG2FCJyKuMneLWsfXq5jHHwjm3fiTvB/dDSNqDFoq2S
         JmXFWwom3xyGJL5obmJ57Otu9AzJREB89K5IN86KfseT3nMcA9ziyA4IzD4CAJVUuIOX
         rY/pCW7HO2zduRDurCQb90y+T+i1YPeXRlyKPiWdcHtgfIlfOvB0RzqMX/uO39w3k+Gd
         TPMp3c1xLJDVxwmEst7U5q/JfgWYlndZe2JTMqPqFWkoIo3EBObw75SAvPOpr36H/e2V
         nKmQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=j3vKy6zd;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id x24si6287670edl.563.2020.05.13.00.31.04;
        Wed, 13 May 2020 00:31:27 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=j3vKy6zd;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731463AbgEMH2r (ORCPT <rfc822;crosarcplusplustest@gmail.com>
        + 99 others); Wed, 13 May 2020 03:28:47 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:17526 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729298AbgEMH2r (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 May 2020 03:28:47 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ebba1260000>; Wed, 13 May 2020 00:26:30 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 13 May 2020 00:28:46 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 13 May 2020 00:28:46 -0700
Received: from [10.40.167.26] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 May
 2020 07:28:43 +0000
Subject: Re: [PATCH] x86/mm: fix compilation error for unknown type name
 pgprot_t
From:   Abhishek Sahu <abhsahu@nvidia.com>
To:     Logan Gunthorpe <logang@deltatee.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Ingo Molnar <mingo@kernel.org>, <x86@kernel.org>,
        Ingo Molnar <mingo@redhat.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
References: <20200420082231.4202-1-abhsahu@nvidia.com>
 <02c40a96-b9dd-14d8-57f4-426322b76bf2@deltatee.com>
 <24e4100d-f59b-daa6-801b-28c9d062f262@nvidia.com>
 <7cdc44e5-4de4-7dea-13c1-536708f12fa2@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <d43c80a4-7e2c-fdd0-b34a-20ba07485844@nvidia.com>
Date:   Wed, 13 May 2020 12:58:38 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <7cdc44e5-4de4-7dea-13c1-536708f12fa2@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1589354790; bh=efIjqqDseHcH1vD6O3AWpKgWaJ3/GNtR1qm3aKhhfa0=;
        h=X-PGP-Universal:Subject:From:To:CC:References:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=j3vKy6zdHJGY0t2cx09VmApg9Websity7UgiExPeWNeBl04nBmCpvxxU8b3Hqp7z+
         jjQsbiRJ691k+uarBdnZDZg15gMx3ZsFmgN0VsZYDxqTYlGQGXHqavZC379HwOpEbb
         p4XmhZRkGMRKPg41A+kj83cK4yoQy0KuQsNtKOKmQJ36CXJ/H3JtXW2yV6BYRCi/Wy
         hbFiCVRMbHBIUIJz5KYex/IfnIESDQ5Ne7ZVucOLocQe3ZiraJWGFgPjw+VHC2a8g7
         PoIrQctu3Z65dc/4YxWbA2MlYtKriJYm+GKXPqN5TqkAT38Hp+79xil3OMK4ca/DGZ
         yh1Da7pSZ77ng==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/27/2020 8:41 PM, Abhishek Sahu wrote:
> On 4/21/2020 11:18 AM, Abhishek Sahu wrote:
>> On 4/20/2020 10:14 PM, Logan Gunthorpe wrote:
>>> On 2020-04-20 2:22 a.m., Abhishek Sahu wrote:
>>>> commit 30796e18c299 ("x86/mm: introduce __set_memory_prot()")
>>>> added the function __set_memory_prot() which uses pgprot_t in
>>>> function prototype. The currently included header files in
>>>> <arch/x86/include/asm/set_memory.h> do not include type name
>>>> pgprot_t. The pgprot_t is defined in <asm/pgtable_types.h>.
>>>>
>>>> Fixes: 30796e18c299 ("x86/mm: introduce __set_memory_prot()")
>>>> Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
>>>
>>> I assume this is only hit with a specific driver or something that
>>> includes set_memory.h without including pgtable_types.h before hand.
>>>
>>> It certainly compiles fine for me and the kbuild robot has had lots of
>>> time to test it with random configs.
>>>
>>> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>>
>>   Thanks Logan.
>>
>>   Yes. The mainline is compiling fine with default config.
>>   This problem is coming while compiling Out of tree NVIDIA driver.
>>   But this problem can happen for the drivers which don't include
>>   <pgtable_types.h>. I am not sure if this problem will come with
>>   some other configs. Normally, the header files should not be
>>   dependent upon the callers.
>>
> 
>  Is it possible to get this patch merged for next rc of 5.7.
>  This issue started coming from 5.7-rc1.
> 

 Could someone help in reviewing and getting this merged in the
 next rc of 5.7 version. The NVIDIA driver compilation is failing
 from 5.7-rc1. This issue can happen for any other driver also
 which is not including <asm/pgtable_types.h> in the driver.

 Thanks,
 Abhishek