Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 May 2020 09:10:04 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Corey Minyard <minyard@acm.org>
Cc:     linux-i2c@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()
Message-ID: <20200513071004.GA1043@ninjato>
References: <20200326210958.13051-1-wsa+renesas@sang-engineering.com>
 <20200326210958.13051-2-wsa+renesas@sang-engineering.com>
 <20200512211425.GQ9902@minyard.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ"
Content-Disposition: inline
In-Reply-To: <20200512211425.GQ9902@minyard.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--rwEMma7ioTxnRzrJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > -	addr_info->added_client =3D i2c_new_device(to_i2c_adapter(adev),
> > -						 &addr_info->binfo);
> > +	addr_info->added_client =3D i2c_new_client_device(to_i2c_adapter(adev=
),
> > +							&addr_info->binfo);
>=20
> i2c_new_client_device returns an ERR_PTR, not NULL on error.  So this

Yes, this is the main motivation for the new API.

> needs some more work.  I'll send something out soon.

Why does it need that work? 'added_client' is only used with
i2c_unregister_device() which has been fixed to handle ERR_PTR as well.
Or am I missing something?


--rwEMma7ioTxnRzrJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl67nUgACgkQFA3kzBSg
KbYyAw//bzqA7h2uelGKYgftZCSyiEKbryeZGdgbRLc8zQ+AlFPUWRsmJLGOeW1G
uCpAq4hz87S6Jr+qt9U1eAYb57Gci6+4A1TzYPTNavShomZz3zqmXp4kVTG1K8pM
7SZOhAjOz8KmctEZYYVaxnt4OOqAWauJCALXi4828LlFg1opfvzPuJZHGUrb7RNa
PuSc6j3+LOu6uZpDQfuEVTDgHbfEkZSsgrziJzRftFH/0+DcjSgjplqufF9RrCcD
Du1DHRWzolmr7IqD/JUxI0u3eAzJpJkEFjZ8548PVqo8ToSAtQHq1H0tidRK+zk3
BUPO+JbSPSwfdnx/T8Uwplwu6pyUGCK6kxKLoCNIkGIqrhltH/tJKkS19KRHUcn6
rV1zaRQTvdNsyK7o18VrDJpjiMYGE7AwZAPaaY8SSx4HUmIwcfZSlK42WwqdDPtA
/97ie52F5W4x+RnuDYdbOeogW4oERSIIOag6X1aJuJWmzevIPc7oz1dWgUAn7w/y
sqjm+87EqYEymHMMQiHpeqWSu7K86eqHPGgjDDuIyILCKPTHoFv6Idp2ZPny/2qG
y/OfwQw+CefEUqrH8ub6wRcFvWS5XcUIXlO0q8Kf/aYAJtcK5HOdn2P7IpB8ZqvI
zmGv4UHK1vJ85XtUHr7IuXr9d8EogzAWPoO6Y3diVF86GFnAhBQ=
=HZtF
-----END PGP SIGNATURE-----

--rwEMma7ioTxnRzrJ--