Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 5/5] lib/test_sysctl: support testing of sysctl. boot
 parameter
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        linux-mm@kvack.org, Ivan Teterevkov <ivan.teterevkov@nutanix.com>,
        Michal Hocko <mhocko@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        "Guilherme G . Piccoli" <gpiccoli@canonical.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Masami Hiramatsu <mhiramat@kernel.org>
References: <20200427180433.7029-1-vbabka@suse.cz>
 <20200427180433.7029-6-vbabka@suse.cz>
 <20200427183913.GH11244@42.do-not-panic.com>
 <028d1996-9f4c-20c6-fb2a-706baa919dde@suse.cz>
 <20200511183155.GT11244@42.do-not-panic.com>
From:   Vlastimil Babka <vbabka@suse.cz>
Message-ID: <d07e1dc9-cc2d-d471-2882-8ec563878fe7@suse.cz>
Date:   Wed, 13 May 2020 10:58:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200511183155.GT11244@42.do-not-panic.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/11/20 8:31 PM, Luis Chamberlain wrote:
> On Mon, May 11, 2020 at 01:05:22PM +0200, Vlastimil Babka wrote:
>> ----8<----
>> From a999e993a89e521b152bbd4b1466f69e62879c30 Mon Sep 17 00:00:00 2001
>> From: Vlastimil Babka <vbabka@suse.cz>
>> Date: Mon, 11 May 2020 12:59:49 +0200
>> Subject: [PATCH] lib/test_sysctl: support testing of sysctl. boot parameter -
>>  fix
>> 
>> Skip the new test if boot_int sysctl is not present, otherwise, per Luis,
>> "This would fail if someone uses this script to test an older kernel, and
>> the scripts in selftests are supposed to work with older kernels."
>> 
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>> ---
>>  tools/testing/selftests/sysctl/sysctl.sh | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh
>> index ef6417b8067b..148704f465b5 100755
>> --- a/tools/testing/selftests/sysctl/sysctl.sh
>> +++ b/tools/testing/selftests/sysctl/sysctl.sh
>> @@ -756,6 +756,11 @@ sysctl_test_0006()
> 
> You want to:
> 
>                                                                                 
> # Kselftest framework requirement - SKIP code is 4.                             
> ksft_skip=4 
> 
>>  sysctl_test_0007()
>>  {
>>  	TARGET="${SYSCTL}/boot_int"
>> +	if [ ! -f $TARGET ]; then
>> +		echo "Skipping test for $TARGET as it is not present ..."
>> +		return 0
>> +	fi
> 
> And return 4 instead.

If I return it from the function, nobody will care, AFAICS. If I 'exit
$ksft_skip', is that correct if it's just a single test out of 7? What's the
proper way?

Thanks

>   Luis
>> +
>>  	if [ -d $DIR ]; then
>>  		echo "Boot param test only possible sysctl_test is built-in, not module:"
>>  		cat $TEST_DIR/config >&2
>> -- 
>> 2.26.2
>> 
>