Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Anson Huang <anson.huang@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec"
 compatible string
Thread-Topic: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec"
 compatible string
Thread-Index: AQHWHg46USvefqc9fky9sVoV8StOh6ilyr0AgAACGXA=
Date:   Wed, 13 May 2020 08:58:42 +0000
Message-ID: <HE1PR0402MB274584C3F6AE70FE6E772374FFBF0@HE1PR0402MB2745.eurprd04.prod.outlook.com>
References: <1588154654-13684-1-git-send-email-fugang.duan@nxp.com>
 <20200513084933.GF26997@dragon>
In-Reply-To: <20200513084933.GF26997@dragon>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ae2984f6-5c48-43e9-85d7-08d7f71bd663
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 08:58:42.7309
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cjEVKkFslDENCnkvsez6hlrEFxu3TAiu8YDJQfDkkaqD/q6J+oTW+M5aQcV7y0HfkkaKR0FDJ2w2CFw47tN4rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3450
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Shawn Guo <shawnguo@kernel.org> Sent: Wednesday, May 13, 2020 4:50 PM
> On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.duan@nxp.com wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK
> > ethernet function can work now.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 9b1616e59d58..b5df957c5063 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -615,7 +615,7 @@
> >                       };
> >
> >                       fec: ethernet@30be0000 {
> > -                             compatible =3D "fsl,imx8mp-fec",
> "fsl,imx8mq-fec";
> > +                             compatible =3D "fsl,imx8mp-fec",
> > + "fsl,imx8mq-fec", "fsl,imx6sx-fec";
>=20
> In this case, "fsl,imx8mq-fec" can be dropped?
>=20
> Shawn
Please don't drop the compatible string, there have little difference for 8=
mq
that support eee feature, the feature will be upstreamed.

Thanks.
>=20
> >                               reg =3D <0x30be0000 0x10000>;
> >                               interrupts =3D <GIC_SPI 118
> IRQ_TYPE_LEVEL_HIGH>,
> >                                            <GIC_SPI 119
> > IRQ_TYPE_LEVEL_HIGH>,
> > --
> > 2.17.1
> >