Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp370860ybk; Wed, 13 May 2020 02:22:51 -0700 (PDT) X-Google-Smtp-Source: APiQypLYOy+49mIayDSmIJaWAKyQYNRM9kjoLg/1cAhI7+SguTbwxF3H4Y1Q63v8ZnJtsJ3eBpft X-Received: by 2002:a50:fa87:: with SMTP id w7mr22230287edr.0.1589361770871; Wed, 13 May 2020 02:22:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589361770; cv=none; d=google.com; s=arc-20160816; b=nbOHDHmH3WC5QOREn+dL9Q7HBwzdcJnfQRliUWrtvhnsg+jSwskfe7Hhpcb/kL+UR9 p+dSgU4qcvyFQFKf4qgLfrJ6hgN58NsLHtWsRKh7wfow8xKEvSlLdzazAr1g4tFPX0yk QlqK7kaUeZWMROLcIMUnSGtFqu5NB311W8VwbtNfJgKbWV5aFE3ZBSYGQvj7qzSOY1mw 3XrEfy7xcbH7//kBbxZm5ftbVmsr5D4opKVYMLPEkFSeACRE2aI2MzE3rg+04i/3iI/X IooaRPZWIgYMi7OWQIpSFdE+Hq4LCyOmvsWc4HBd2Ga2Q24XPNE9Kr1e+CgZQlnGK2lF HZHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7wkuU7gnCdA/dr4gSpLdo2O+0miJazYotN9F6ofkofg=; b=lWdXlnyuEwKwMqzujO21O1FL++CdPgxVNDaS3dVR8JoqPzz3JM1Fo3wPyMunNmhJuC 4gv356tM2mGK6fiL/AdaBOc/FGMG7Dp1gV9bgY0fF6nCbHFRglncJWWzFEoM2wOuTgbZ zmnI368AsLgwKSvjr8rXBDpjOx04UmOfOYuOwpu0ZV28pqyahGWepH5SrQS4myRRzc2o t8xu89IrP9SnkLkadOPTdFebCSYa4H5tjkNYLK4qsJ+o8wJmtptXdksvkgrszNUaiAgh 0Qwoy9G6mrMSsioTZCF0XPpulmglCiOf257IiG2r2QQZ3SNzd4f/IbZM8D+HKj2m2gfh TUoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy28si392866edb.565.2020.05.13.02.22.24; Wed, 13 May 2020 02:22:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728145AbgEMJUt (ORCPT + 99 others); Wed, 13 May 2020 05:20:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728068AbgEMJUt (ORCPT ); Wed, 13 May 2020 05:20:49 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09777C061A0E for ; Wed, 13 May 2020 02:20:49 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYnZ9-0005Uj-6g; Wed, 13 May 2020 11:20:39 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jYnZ8-00072r-Or; Wed, 13 May 2020 11:20:38 +0200 Date: Wed, 13 May 2020 11:20:38 +0200 From: Sascha Hauer To: Robin Gong Cc: "vkoul@kernel.org" , "shawnguo@kernel.org" , "u.kleine-koenig@pengutronix.de" , "robh+dt@kernel.org" , "festevam@gmail.com" , "dan.j.williams@intel.com" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "l.stach@pengutronix.de" , "martin.fuzzey@flowbird.group" , "kernel@pengutronix.de" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165 Message-ID: <20200513092038.GR5877@pengutronix.de> References: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com> <1589218356-17475-8-git-send-email-yibin.gong@nxp.com> <20200513072132.GL5877@pengutronix.de> <20200513084815.GP5877@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:20:29 up 83 days, 16:50, 119 users, load average: 0.32, 0.19, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 08:52:39AM +0000, Robin Gong wrote: > On 2020/05/13 16:48 Sascha Hauer wrote: > > On Wed, May 13, 2020 at 08:38:26AM +0000, Robin Gong wrote: > > > On 2020/05/13 Sascha Hauer wrote: > > > > This patch is the one bisecting will end up with when somebody uses > > > > an older SDMA firmware or the ROM scripts. It should have a better > > > > description what happens and what should be done about it. > > > Emm..That's true. Timeout will be caught in such case, hence, maybe we can > > fall back it to pio always. > > > > With my patch applied sdma_load_context() will fail. I don't know how exactly > > this hits into the SPI driver, but it won't be a timeout. > Thanks for your quick test, assume you use ROM firmware, right? Yes. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |