Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp387515ybk; Wed, 13 May 2020 02:52:47 -0700 (PDT) X-Google-Smtp-Source: APiQypJLQSMbOFt8mo7EMXbHK871vGzdXGnxwS1uRX/fj+XtKCW+PrTVDS4Y3LpDhClfMZhLAws9 X-Received: by 2002:a17:906:2e4a:: with SMTP id r10mr18712505eji.116.1589363567121; Wed, 13 May 2020 02:52:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589363567; cv=none; d=google.com; s=arc-20160816; b=UKJEyrDc3x6HpWpYAESK4PysJ/BVCAfbmflBRB6N+MP0Cwx5a6AtJOX3QGvkkTDw8s WGNdQZspecv/r3Kqpc6ObjvvwEoKT45/q9uV1XE13gOSjq+LwwvZaANAxScXQaZ0lkhm 1Tvlb3lbtgsp8Sd1VpWsA5fkrKhUui+sn/wpsDp4nnie7TYPuECaGjzb1FZeGUgLiM1P Od6XgR0i1nKIPND2guJQGWyjxN06UsCsiAU4Jkt19ClEBMq9mPw57O8PdLLCwKseS0an qrrt810y+80I7lnAQXKHzCVXXG9TNTNUX8qVYcXEqyMKjHjiOG9wLaoEJMS428OVffyc Vxrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vI1HSpo7JSbwTRD9lhLBPGbReloovre1TONkkWI4K8s=; b=cQntGKIArigx93bp1Na8UM2OAMI+bCI0Reb4jHiDtmr5Uq+YgbtyX/pkphxB5BCPT+ zdfBl4VW1Sw1eqqU2ZHqcb+4Qq2BpSvOtt5Yx6a7HjVJ2RWYl2n0T/eLoKkrVyhzTuGk SI5pQ1qlQdqs6BoYaaNXysqIj8P0O8++S1NUfebkcwXuT+BPdIIKQlB1lc4HpXpWZUUX x25cM7hdP1B8NQjOvjpY+yHytXwYFLMQ1GdyRd9UT+8rEcXPjKIXbVbruOfMjb11OknX Yyb0HXw4FNmiXImSsRK9IF34Y2BkrN55LscMEdGp9u5TermoZlj9ut6TBEqdQUrezAvr cK/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cI5NR0Fm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me7si8738217ejb.191.2020.05.13.02.52.24; Wed, 13 May 2020 02:52:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cI5NR0Fm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387430AbgEMJuB (ORCPT + 99 others); Wed, 13 May 2020 05:50:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387418AbgEMJt6 (ORCPT ); Wed, 13 May 2020 05:49:58 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0B76C061A0C; Wed, 13 May 2020 02:49:58 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id u10so6618558pls.8; Wed, 13 May 2020 02:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vI1HSpo7JSbwTRD9lhLBPGbReloovre1TONkkWI4K8s=; b=cI5NR0Fmf0b3v4RmzfC93mlJjUuGrnz+wojY6kn0wMKI0CqhzbAaR68zlAPTfc8dlv nEo440GlsOwFtHLvmIwgjuS3b21nqoISVskSnOTWHvxRLJrdNWFj6QMTmLmtSrHcvII1 f21gkgvPL17ChZSaMzaeZarWmyda5FX9Kr5ukmdzmNBgSSse2lehTc0Ks5vhNtVA0/mE 9rpVuAwhTwRu4icbbs7byMez/Yo1v+A11a88VyXl7uI1WJZAZarE356ybl82sEjjXRZ5 8G2lnX/haRNYHv8EmMYC+JvmoyXtaKWUhedE/OBMwOR4zYnDyClehHQNyZI5AqEinVaV sbng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vI1HSpo7JSbwTRD9lhLBPGbReloovre1TONkkWI4K8s=; b=abcJAl2ciZe1+rQEyAm0KavHP1h120wmdnahsKjDU0VQBCwljrm1YKMih15GGmO2+a c7R0Kf83OWxOinsJ9d5XKvy6Lk71Q0gh/vkFn0l/AAgCoGuBBBQaYzmwEwUq35jyEkX+ A/K1hqw9CYUdf/qzC6qyb99FzXbUoZOcUI/S+7YDqJc9OlPO0r5VBZa5qAohxE0C/4zq siNy7fNGlXCV97TBLUy8p78m7QX34FXVn1LcepyvpF2iyiONLIOJE2U8267SUxooOyQ3 N49vO+Cobfgxc/h+36PZ1m3IiNhsmxXtjS8A5mPmRyZNkqA6ToillKlRjzmIwLeFJSv2 Dicw== X-Gm-Message-State: AGi0PuY445Iqi3v54nG6GlPWwD83cdT77UbY982OxGpObje+WDxxM48Z +rFP3uvnUOvmTtc1Kf6fZRg292nUgMyxPkTWFAo= X-Received: by 2002:a17:90b:3717:: with SMTP id mg23mr34645016pjb.129.1589363398238; Wed, 13 May 2020 02:49:58 -0700 (PDT) MIME-Version: 1.0 References: <1589361736-816-1-git-send-email-jprakash@codeaurora.org> <1589361736-816-5-git-send-email-jprakash@codeaurora.org> In-Reply-To: <1589361736-816-5-git-send-email-jprakash@codeaurora.org> From: Andy Shevchenko Date: Wed, 13 May 2020 12:49:51 +0300 Message-ID: Subject: Re: [PATCH V4 4/5] iio: adc: Update error checks and debug prints To: Jishnu Prakash Cc: agross@kernel.org, Bjorn Andersson , devicetree , Linux Kernel Mailing List , Matthias Kaehlcke , Linus Walleij , Jonathan Cameron , Amit Kucheria , smohanad@codeaurora.org, kgunda@codeaurora.org, aghayal@codeaurora.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-iio , linux-arm-msm-owner@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 12:23 PM Jishnu Prakash wrote: > > Change pr_err/pr_debug statements to dev_err/dev_dbg for > increased clarity. Also clean up some return value checks. 'Also' on the commit message == 'split this to two'. But here is a ping pong style of patches (you introduce a problem in one patch and fix it in the following). -- With Best Regards, Andy Shevchenko