Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
Date:   Wed, 13 May 2020 11:44:01 +0100
From:   Brian Starkey <brian.starkey@arm.com>
To:     Rob Herring <robh@kernel.org>
Cc:     John Stultz <john.stultz@linaro.org>,
        Robin Murphy <robin.murphy@arm.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Andrew F. Davis" <afd@ti.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Liam Mark <lmark@codeaurora.org>,
        Pratik Patel <pratikp@codeaurora.org>,
        Laura Abbott <labbott@redhat.com>,
        Chenbo Feng <fengc@google.com>,
        Alistair Strachan <astrachan@google.com>,
        Sandeep Patil <sspatil@google.com>,
        Hridya Valsaraju <hridya@google.com>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-mm <linux-mm@kvack.org>, nd <nd@arm.com>
Subject: Re: [RFC][PATCH 3/4] dma-buf: cma_heap: Extend logic to export CMA
 regions tagged with "linux,cma-heap"
Message-ID: <20200513104401.lhh2m5avlasev6mj@DESKTOP-E1NTVVP.localdomain>
References: <20200501073949.120396-1-john.stultz@linaro.org>
 <20200501073949.120396-4-john.stultz@linaro.org>
 <20200501102143.xcckvsfecumbei3c@DESKTOP-E1NTVVP.localdomain>
 <47e7eded-7240-887a-39e1-97c55bf752e7@arm.com>
 <CALAqxLU6kmvJ+xPCFzc3N+RNMv4g=L9bmzgE0wrOXefiGfPoHg@mail.gmail.com>
 <20200504090628.d2q32dwyg6em5pp7@DESKTOP-E1NTVVP.localdomain>
 <20200512163714.GA22577@bogus>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200512163714.GA22577@bogus>
User-Agent: NeoMutt/20180716-849-147d51-dirty
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from DESKTOP-E1NTVVP.localdomain (217.140.99.251) by LO2P265CA0418.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Wed, 13 May 2020 10:44:02 +0000
X-Originating-IP: [217.140.99.251]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: b2a0d7be-2e20-4cc0-c98c-08d7f72aaae8
X-MS-TrafficTypeDiagnostic: HE1PR08MB2812:|HE1PR08MB2812:|DB6PR0802MB2279:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DB6PR0802MB2279CC076478AE49D82C3106F0BF0@DB6PR0802MB2279.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-Forefront-PRVS: 0402872DA1
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: zMInwp+bMlGCdR9tW1ECY7EZALjsJAXPRDVRqxqx0cN0qmt9VCyhvhOCRz3vZB1g+gqtTloP9mcak34iuVx1YCrW39O9V4EX2ejBs4fE/I5VEpPL3o/gYtOnS1EnByYEVMxWZ0a2xKlOpRDi2qJ46FzaSe2UwjPTZtyAurOs1Gn9mECPR0746DyDcEfd4sEdPmRqseDKCDl9wR/KwQFu1J3/FyIfejW+EnQUA6bXjdUFOy9Oh5Oa6IGzcpEQe52EDPTW4ncf+1uka/d0jvoiC/nvKFKnuM9O/jyYvj4HSXCFw3v5Ad4k6x1r1zt1CmHYNWPwK3BTM7UsY7OC+26yOAcVvNsmopvuEf3tZCoKIN6B2PzCkiaeeqyXIELMuPcAQecvHv5SY/NakTLzbhQTnq83yZb/LrMLbG79pdY7SGx4O7tVjlPFewgqSXxeUjTOovMpvJlH7qY3KIQ1Tl+n/MCiKlwMPLfxleRuLbPNNqf7SWDxIQxp+IXrcOoQJ6uWg9j/HG5a+f1I1UJfHIdojnVe46TTBhztKrmFChLbgZ99SJKw33ixRb1+0txyNhox
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR08MB2890.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(33430700001)(6506007)(6916009)(5660300002)(7416002)(956004)(186003)(26005)(4326008)(16526019)(8676002)(55016002)(44832011)(8936002)(9686003)(1076003)(2906002)(54906003)(53546011)(66556008)(52116002)(316002)(66476007)(7696005)(66946007)(86362001)(33440700001)(478600001)(142933001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: uDzDpuLKwz1jGTAXC0HHowpA/Q6EU8XSFLPOycAh2YG7fvAJCtU/1THQ4qxqk2YTTLUH0Xw+98fPIlSYlgILJy1zRUwFXoAuAdxTW7/u2Rl+T2u9rZCfrR3MxqWshATkI8uLKkaATxmLEVathot3KoCQd+3gr8BVI3WrhBT6CpvOV6PVNXSk+PxCUgGw19QxezoTKcnQlEM8hz1P4yBj6ELTfELMlze49OteHPUdMjEvux0SItjdOaGAC4jIH/wgNiwlfVGegzLro/kLHHyHW9V3d569ksvwD0GcI2MnPWKSWIR867rEsKjIeKYnb2VpQy5YPHjECbrCBwNSj1dmWp57eDiM6vbhFisyG8iFC6V85r/LoU3dvoJPEY4miGxD2fUF5U3c0HxoYwnXbq+oWxJvmpktsSh2ae4dP3vpPhKoiqbuXIQFth903DEdJAIHmv3K2OBhw7QnoC6gk15FSuOe8Z4mWL0PwGC4blLbyfjX+w3S5HUAz9Oqf8WjnSVZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2812
Original-Authentication-Results: kernel.org; dkim=none (message not signed)
 header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966005)(33430700001)(2906002)(82310400002)(55016002)(5660300002)(82740400003)(86362001)(450100002)(47076004)(81166007)(9686003)(6862004)(316002)(336012)(36906005)(70206006)(4326008)(956004)(70586007)(16526019)(54906003)(53546011)(8936002)(44832011)(356005)(26005)(8676002)(7696005)(186003)(6506007)(478600001)(1076003)(33440700001)(142933001);DIR:OUT;SFP:1101;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 0850e977-7095-42c7-0343-08d7f72a8dd5
X-Forefront-PRVS: 0402872DA1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UdORZwtaYYPIQUvUNhPdp4VNmDx4cyymY4rZmaDnt5Ztp09GqnhXSIi+dOswUu0GgF+kJnmbjH/TtvHHF9MvpsC1ZPCTLF0p7vqGiuEcxG6LhQXyDNdxgne4Dra7zBaN7QuRFsZEVGIpuwNQb1RvdWaPbMQJSzKubXZhyJ0fVUt9RzPx0zNalwXWOmoZQ/yRGUI/8fVDM11M2UupYTKvE7fmTiAjIRLqhf2pS+Ywi/aTo/SDkxrLPJyOgjhl2X/uzzViHfrVUaxshK5mMlgGV+jfAEUwY6IM5zsj+3gi2uv1KiD8QzdOzzAuCIC3Ui450QmW5Os9xTdh70mBTdpLcFIYhUJrkCJoWl+poJtGgrwLlT/A0Xjk8mptO0htGmxF6DL4f9AHUDyqsM/ENptNtT6eGdGG3Pdp3Pq6SfszZKa92RfbYYWiARpgg2XIWWOi+XuPqLuqWXtKXi+gKGVOvzRxZc2sV3M4AaFaIz/qMwPqnX8wJGCQW10+3mcP9D0Kw8NDaVzKjQKOlYZCt+XvjbVYmvik6XPduX8E93E8o8FUmzAKiY3YkatjAsKoOyA+nejCM5RgriCrdTjuHXPVu3R/pH4a8AbAiyk/rlFHDS0=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2020 10:44:52.2685
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b2a0d7be-2e20-4cc0-c98c-08d7f72aaae8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2279
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On Tue, May 12, 2020 at 11:37:14AM -0500, Rob Herring wrote:
> On Mon, May 04, 2020 at 10:06:28AM +0100, Brian Starkey wrote:
> > On Fri, May 01, 2020 at 12:01:40PM -0700, John Stultz wrote:
> > > On Fri, May 1, 2020 at 4:08 AM Robin Murphy <robin.murphy@arm.com> wrote:
> > > >
> > > > On 2020-05-01 11:21 am, Brian Starkey wrote:
> > > > > Hi John,
> > > > >
> > > > > On Fri, May 01, 2020 at 07:39:48AM +0000, John Stultz wrote:
> > > > >> This patch reworks the cma_heap initialization so that
> > > > >> we expose both the default CMA region and any CMA regions
> > > > >> tagged with "linux,cma-heap" in the device-tree.
> > > > >>
> > > > >> Cc: Rob Herring <robh+dt@kernel.org>
> > > > >> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > > > >> Cc: "Andrew F. Davis" <afd@ti.com>
> > > > >> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> > > > >> Cc: Liam Mark <lmark@codeaurora.org>
> > > > >> Cc: Pratik Patel <pratikp@codeaurora.org>
> > > > >> Cc: Laura Abbott <labbott@redhat.com>
> > > > >> Cc: Brian Starkey <Brian.Starkey@arm.com>
> > > > >> Cc: Chenbo Feng <fengc@google.com>
> > > > >> Cc: Alistair Strachan <astrachan@google.com>
> > > > >> Cc: Sandeep Patil <sspatil@google.com>
> > > > >> Cc: Hridya Valsaraju <hridya@google.com>
> > > > >> Cc: Christoph Hellwig <hch@lst.de>
> > > > >> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > > > >> Cc: Robin Murphy <robin.murphy@arm.com>
> > > > >> Cc: Andrew Morton <akpm@linux-foundation.org>
> > > > >> Cc: devicetree@vger.kernel.org
> > > > >> Cc: dri-devel@lists.freedesktop.org
> > > > >> Cc: linux-mm@kvack.org
> > > > >> Signed-off-by: John Stultz <john.stultz@linaro.org>
> > > > >> ---
> > > > >>   drivers/dma-buf/heaps/cma_heap.c | 18 +++++++++---------
> > > > >>   1 file changed, 9 insertions(+), 9 deletions(-)
> > > > >>
> > > > >> diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
> > > > >> index 626cf7fd033a..dd154e2db101 100644
> > > > >> --- a/drivers/dma-buf/heaps/cma_heap.c
> > > > >> +++ b/drivers/dma-buf/heaps/cma_heap.c
> > > > >> @@ -141,6 +141,11 @@ static int __add_cma_heap(struct cma *cma, void *data)
> > > > >>   {
> > > > >>      struct cma_heap *cma_heap;
> > > > >>      struct dma_heap_export_info exp_info;
> > > > >> +    struct cma *default_cma = dev_get_cma_area(NULL);
> > > > >> +
> > > > >> +    /* We only add the default heap and explicitly tagged heaps */
> > > > >> +    if (cma != default_cma && !cma_dma_heap_enabled(cma))
> > > > >> +            return 0;
> > > > >
> > > > > Thinking about the pl111 thread[1], I'm wondering if we should also
> > > > > let drivers call this directly to expose their CMA pools, even if they
> > > > > aren't tagged for dma-heaps in DT. But perhaps that's too close to
> > > > > policy.
> > > >
> > > > That sounds much like what my first thoughts were - apologies if I'm
> > > > wildly off-base here, but as far as I understand:
> > > >
> > > > - Device drivers know whether they have their own "memory-region" or not.
> > > > - Device drivers already have to do *something* to participate in dma-buf.
> > > > - Device drivers know best how they make use of both the above.
> > > > - Therefore couldn't it be left to drivers to choose whether to register
> > > > their CMA regions as heaps, without having to mess with DT at all?
> 
> +1, but I'm biased toward any solution not using DT. :)
> 
> > > I guess I'm not opposed to this. But I guess I'd like to see some more
> > > details? You're thinking the pl111 driver would add the
> > > "memory-region" node itself?
> > > 
> > > Assuming that's the case, my only worry is what if that memory-region
> > > node isn't a CMA area, but instead something like a carveout? Does the
> > > driver need to parse enough of the dt to figure out where to register
> > > the region as a heap?
> > 
> > My thinking was more like there would already be a reserved-memory
> > node in DT for the chunk of memory, appropriately tagged so that it
> > gets added as a CMA region. 
> > 
> > The device's node would have "memory-region=<&blah>;" and would use
> > of_reserved_mem_device_init() to link up dev->cma_area to the
> > corresponding cma region.
> > 
> > So far, that's all in-place already. The bit that's missing is
> > exposing that dev->cma_area to userspace as a dma_heap - so we could
> > just have "int cma_heap_add(struct cma *cma)" or "int
> > cma_heap_dev_add(struct device *dev)" or something exported for
> > drivers to expose their device-assigned cma region if they wanted to.
> > 
> > I don't think this runs into the lifetime problems of generalised
> > heaps-as-modules either, because the CMA region will never go away
> > even if the driver does.
> > 
> > Alongside that, I do think the completely DT-driven approach can be
> > useful too - because there may be regions which aren't associated with
> > any specific device driver, that we want exported as heaps.
> 
> And they are associated with the hardware description rather than the 
> userspace environment? 

I'm not sure how to answer that. We already have CMA regions being
created from device-tree, so we're only talking about explicitly
exposing those to userspace.

Are you thinking that userspace should be deciding whether they get
exposed or not? I don't know how userspace would discover them in
order to make that decision.

Thanks,
-Brian

> 
> Rob