Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp426505ybk; Wed, 13 May 2020 03:59:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytMlkaHVakLdEgDIto2v0imW3lNv9lPTsAySjeAsreMIjYxZgVVAEMy7g1TSw4GwCSf7u4 X-Received: by 2002:a05:6402:17a3:: with SMTP id j3mr13407036edy.137.1589367540823; Wed, 13 May 2020 03:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589367540; cv=none; d=google.com; s=arc-20160816; b=FzPB94zQRCGcj9dJpPQQJUIJZSUor/s27xd/S898DnKLT0EBH+tjb6TDwEu9Mo5Vl4 SQ/tecQfSfsva0QCacADq1w/v1/BP876Evl2NLHjMwH6g4k7qNzlF1DT+e0zj8bk9hAq B7xYa0EyjM57cKoU4+8QchR1aauQcFtmFm5hk90sa/HAAuYkiS6FqCOtulfBwlhX3VSc qw3htaJ334i221uNje7pNO7Ge/jsZK+oOgnqNuCMY+A31O3oOcIttkCQfgusyyoBtQEZ s6Gzr3g5K302zQfAV3V0lrGp61kcG5YvXhCtyFyVZ4bkGVGzW2JonkBRtk3sOmeWiDLp NWKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WfXUbr9x36FiC7mCzfGpvGx3wprUtxJ7TQ8tE1TmP7Q=; b=cEJoaVdp5iFeUGqZfp1hZUZ8ttDLJTjlPG2ewT9l2v9nXCrMKuxrM4HM+NOfspu3ee 2ng4H5aZA78KubzXulY3T3xKDbYNmAm7R8W1OI+mKXQCCV6cUeAhS6m6EWTZ+PWIU4wb XSc0knIFEorruo16HvwlOyu8dVryk9dTZuDNJ7aKb5z0Xf59DCKc9FTksDAEa3TlyF65 aIwbcnfLXi6a3difxPUrGOI028ZBPa3DaN6vPZGVmLrGvIg7V10YqZonLC7VedVRv/W0 mB356jIFQeL4w3JYfpnbTB5f0ABlVgwcFKrA2Wgv3AmxhQw8fVYnF0NI6mm98D1UuNZK K9vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m31si1027116ede.443.2020.05.13.03.58.37; Wed, 13 May 2020 03:59:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728964AbgEMGHX (ORCPT + 99 others); Wed, 13 May 2020 02:07:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726220AbgEMGHW (ORCPT ); Wed, 13 May 2020 02:07:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84FE2C061A0C for ; Tue, 12 May 2020 23:07:22 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYkWG-0000uB-3T; Wed, 13 May 2020 08:05:28 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jYkWD-0003jr-LK; Wed, 13 May 2020 08:05:25 +0200 Date: Wed, 13 May 2020 08:05:25 +0200 From: Sascha Hauer To: Robin Gong Cc: vkoul@kernel.org, shawnguo@kernel.org, u.kleine-koenig@pengutronix.de, robh+dt@kernel.org, festevam@gmail.com, dan.j.williams@intel.com, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, l.stach@pengutronix.de, martin.fuzzey@flowbird.group, kernel@pengutronix.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache" Message-ID: <20200513060525.GJ5877@pengutronix.de> References: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com> <1589218356-17475-4-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589218356-17475-4-git-send-email-yibin.gong@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:04:32 up 83 days, 13:35, 87 users, load average: 0.05, 0.22, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote: > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since > 'context_loaded' finally removed. > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 4d4477d..3d4aac9 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1338,7 +1338,6 @@ static void sdma_free_chan_resources(struct dma_chan *chan) > > sdmac->event_id0 = 0; > sdmac->event_id1 = 0; > - sdmac->context_loaded = false; > > sdma_set_channel_priority(sdmac, 0); I think this can safely be folded into the next patch which makes it more clear what is happening. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |