Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: bSt1y5g9hd82+0lAcwRJKt7V61CYoZ4HYnxQq5e9hYBIUmra0bMF3+90A8LRP4uCuXNo7udIbU
 /YoAJ1w6eYCPw37sb8E3CtE1Y6MZ8BFwFI1sVs8/EAPHWwxMdHXKYIh9+yhcLqbHJVbQmud7mz
 fbpQEKO8Gkmw+zjyShRiJgqgNyMy/QkBof47QSHpsSghc977Dpa8oITmWH4awCzhY+r3/kXbfj
 jZf8MrVOiLM0BJB/KzU9TozPzSNQVvYw244V+r93qDo73+OXoF6zNdO5yRPsk8ENLdebk5vjF2
 Guk=
From:   <Codrin.Ciubotariu@microchip.com>
To:     <wsa@the-dreams.de>
CC:     <linux-gpio@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <Ludovic.Desroches@microchip.com>,
        <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
        <kamel.bouhara@bootlin.com>, <linux@armlinux.org.uk>,
        <linus.walleij@linaro.org>, <alan@softiron.com>
Subject: Re: Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for
 bus recovery
Thread-Topic: Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for
 bus recovery
Thread-Index: AQHWEvR+GtAbavRk40KvRq7DN8dZF6iZuWYAgAxN9wA=
Date:   Wed, 13 May 2020 11:07:07 +0000
Message-ID: <c7a35978-03dd-3c73-6e7d-15ed40b5c57c@microchip.com>
References: <20200415070643.23663-1-codrin.ciubotariu@microchip.com>
 <20200505151256.GF2468@ninjato>
In-Reply-To: <20200505151256.GF2468@ninjato>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <F5A71579395B20448F9FB36722E0C959@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e7c7028-1124-4569-e1bf-08d7f72dc677
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 11:07:07.0519
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3eMS1Kv4UtX3thuxxvsW5NNZtKuuhH0+lmqeGHhonXL2J+00FiNLqChhdPeVmdx8j85EaBlR/HnyjMiisI2j1w71tKZMn5KkyV1Xm4ie4zU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1752
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05.05.2020 18:12, Wolfram Sang wrote:
> On Wed, Apr 15, 2020 at 10:06:43AM +0300, Codrin Ciubotariu wrote:
>> devm_gpiod_get() usually calls gpio_request_enable() for non-strict pinm=
ux
>> drivers. These puts the pins in GPIO mode, whithout notifying the pinctr=
l
>> driver. At this point, the I2C bus no longer owns the pins. To mux the
>> pins back to the I2C bus, we use the pinctrl driver to change the state
>> of the pins to GPIO, before using devm_gpiod_get(). After the pins are
>> received as GPIOs, we switch theer pinctrl state back to the default
>> one,
>>
>> Fixes: d3d3fdcc4c90 ("i2c: at91: implement i2c bus recovery")
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>=20
> Applied to for-current, thanks!

Just looked at this patch and noticed that I should change the pinctrl=20
state back to default if we can't get the gpio pins. I will submit a=20
patch to fix this.

>=20
> This will do for 5.7. For 5.8 or 5.9, I can imagine to take the two
> pinctrl_state pointers into bus_recovery_info and handle all this in the
> core. I will try this later this week if noone is super-eager to try it
> out before.
>=20

By 'all this' you mean to move the entire function in the core, right?=20
Having just these two pointers bus_recinovery_info won't help much. I=20
can try it, if you haven't already started...

Best regards,
Codrin