Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp543747ybk; Wed, 13 May 2020 06:51:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVJEOsBOl5Ni+5t6UM3pEutOEz6kl9XhqDzEBVufDkQO1VxknzHUas0XQpeultie4+Kh/r X-Received: by 2002:a50:f40e:: with SMTP id r14mr2262607edm.241.1589377915536; Wed, 13 May 2020 06:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589377915; cv=none; d=google.com; s=arc-20160816; b=cxfGk5VXibaP1ZG1/hjgFbXwO/yCecURsk8uYnF+6gC/Ixu8AtXjEjsIZXtb6/trOR 1WCJ4yEjx0LFUHCszSmBje209fMqOzCha7ugKyTNMADcWNA7VSGd1VtsgWfp64zpbPd5 B1sdwBuO4WzoMiElRLVWxU8dyW1RJXaAbeurfHIsw82d/aw/MUFK/6JPk4CzMc65223w /rkLSS/kZ3kukcQDH1eHXEWIjJcp1Ym6MoRfVQ0NIQIu8MlKLKjUJwGJj+FGJvDOjo8z ZvehTB9bc1V01iE8Y4zZUUK+KBGynbO8c9jUfb6PE4LJAgF2tLhuw3Y8H4JxRLNb/RYQ 9z0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vE3N/bgCOSuBsuoedjezPDBuOaPIgi01RG5Bucwqlu8=; b=AxMU6Z/ncx6VKkWw82E7YE8pIOu3aXpxCa8eCnvd4jURb700EtyymS3vQ3HX49sBNa 6VHbUFscCWuKxbz9lCKRz1nxMcBiAZz1AEpfZTmA1TRFaIdaHDTmGVW1vGaqVwKw3g/z yRLBI8tj8Q9MaezJjomcjZw3CA9hLcClPSRI0JqTq0mSSJckSFzVF+fkNVDtdbYgJVN9 9iUQfdB6Aa4O2SPAZrPoOeeZM2G9agMZGz2i4+i0y3X6WR0WulmOKkuFvHOmguGza0vG 8XXPpk/5hn1Er3gaezcDYO2Ih4vcriSngS2SZYRiuPZqOwK6URk0Xwc15hXA43FvKrt1 kEgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=ewcl5ODp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn1si6584400ejc.7.2020.05.13.06.51.32; Wed, 13 May 2020 06:51:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=ewcl5ODp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388745AbgEMNta (ORCPT + 99 others); Wed, 13 May 2020 09:49:30 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57966 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727792AbgEMNta (ORCPT ); Wed, 13 May 2020 09:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vE3N/bgCOSuBsuoedjezPDBuOaPIgi01RG5Bucwqlu8=; b=ewcl5ODpAGeimIVHP1ORPWJEFl QIJBqbAhMG7S4Plui+l8Ele2Wr4GEWqKdI8dth1eWMUbgvCcd22tHLWy8Hlnc2F/LD7MVRhdm+j6e aAW5YRVXbg20bp05k8hUBL3e3VHZdFBbnaUCF0IUE3+DBg4hUtS6Wrg9YgysqUc8j+Fo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jYrlF-002ARp-BL; Wed, 13 May 2020 15:49:25 +0200 Date: Wed, 13 May 2020 15:49:25 +0200 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Doug Berger , "David S. Miller" , Florian Fainelli , Heiner Kallweit , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting Message-ID: <20200513134925.GE499265@lunn.ch> References: <1589243050-18217-1-git-send-email-opendmb@gmail.com> <1589243050-18217-2-git-send-email-opendmb@gmail.com> <20200512004714.GD409897@lunn.ch> <20200512185503.GD1551@shell.armlinux.org.uk> <0cf740ed-bd13-89d5-0f36-1e5305210e97@gmail.com> <20200513053405.GE1551@shell.armlinux.org.uk> <20200513092050.GB1605@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513092050.GB1605@shell.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So, I think consistency of implementation is more important than fixing > this; the current behaviour has been established for many years now. Hi Russell, Doug With netlink ethtool we have the possibility of adding a new API to control this. And we can leave the IOCTL API alone, and the current ethtool commands. We can add a new command to ethtool which uses the new API. Question is, do we want to do this? Would we be introducing yet more confusion, rather than making the situation better? Andrew