Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] printk: Add loglevel for "do not print to consoles".
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Michal Hocko <mhocko@kernel.org>, linux-kernel@vger.kernel.org,
        Dmitry Safonov <dima@arista.com>,
        Yafang Shao <laoar.shao@gmail.com>
References: <20200427062117.GC486@jagdpanzerIV.localdomain>
 <4dae86af-1d9a-f5a8-cff6-aa91ec038a79@i-love.sakura.ne.jp>
 <20200428121828.GP28637@dhcp22.suse.cz>
 <b4d74234-8009-9ffd-011f-bd5d1a4b85f6@i-love.sakura.ne.jp>
 <20200428154532.GU28637@dhcp22.suse.cz>
 <b1d507b1-dae7-f526-c74a-d465ddecea6a@i-love.sakura.ne.jp>
 <20200429142106.GG28637@dhcp22.suse.cz>
 <a59271f1-b3fc-26d1-f0a2-5ec351d0095e@i-love.sakura.ne.jp>
 <20200513062652.GM413@jagdpanzerIV.localdomain>
 <a75d6560-ad99-5b02-3648-247c27c3a398@i-love.sakura.ne.jp>
 <20200513100413.GH17734@linux-b0ei>
 <20564555-7b84-f716-5dcd-978f76ad459a@i-love.sakura.ne.jp>
 <20200513095503.7488b0d6@gandalf.local.home>
From:   Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Message-ID: <5f272afb-2d74-c051-ce0a-4332ff080ef3@i-love.sakura.ne.jp>
Date:   Thu, 14 May 2020 00:20:04 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200513095503.7488b0d6@gandalf.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/05/13 22:55, Steven Rostedt wrote:
> On Wed, 13 May 2020 20:03:53 +0900
> Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
> 
>> I think that basically only oops (e.g. WARN()/BUG()/panic()) messages worth
>> printing to consoles and the rest messages do not worth printing to consoles.
>> Existing KERN_$LOGLEVEL is too rough-grained.
> 
> Why don't you look into having a "noconsole" command line option that will
> not print anything to the consoles but oops messages.

Well, such global option can be as harmful as "ignore_loglevel" command line
option in that we have to worry about how per-console loglevel can co-exist.

The idea of per-console loglevel is to allow specifying different threshold
based on characteristics of each console while the effect of ignore_loglevel
is to disallow specifying different threshold. (I'm wondering whether
ignore_loglevel should be valid under CONSOLE_LOGLEVEL_SILENT, for
CONSOLE_LOGLEVEL_SILENT says "don't print to consoles" while ignore_loglevel
says "always print to consoles".)

If we want to implement per-console loglevel in the future, shouldn't we first
deprecate the conflicting "ignore_loglevel" command line option (and get rid
of it by asking users to use LOGLEVEL_DEBUG as console loglevel)?

The idea of "noconsole" command line option is to disallow printing almost all
messages regardless of KERN_$LOGLEVEL while the idea of per-console loglevel is
to allow printing some messages based on KERN_$LOGLEVEL.

> 
> Sounds more like what you would like, and something that perhaps would be
> acceptable by the larger community.

More we introduce global switches, more difficult to introduce fine-grained
switches (e.g. per-console loglevel).