Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>
CC:     "vkoul@kernel.org" <vkoul@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165
Thread-Topic: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165
Thread-Index: AQHWJ3cnZ0DWmxBZKkqSbDLRijv4Zqiln1IAgAATtwCAAASDgIAAAJXwgAAIeACAAB4RQA==
Date:   Wed, 13 May 2020 15:48:22 +0000
Message-ID: <VE1PR04MB663876FA31A281A388F2BBEB89BF0@VE1PR04MB6638.eurprd04.prod.outlook.com>
References: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com>
 <1589218356-17475-8-git-send-email-yibin.gong@nxp.com>
 <20200513072132.GL5877@pengutronix.de>
 <VE1PR04MB6638F5096376BA0AF204C64189BF0@VE1PR04MB6638.eurprd04.prod.outlook.com>
 <20200513084815.GP5877@pengutronix.de>
 <VE1PR04MB6638857DD94A05DC7252E69589BF0@VE1PR04MB6638.eurprd04.prod.outlook.com>
 <20200513092038.GR5877@pengutronix.de>
In-Reply-To: <20200513092038.GR5877@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/mixed;
        boundary="_002_VE1PR04MB663876FA31A281A388F2BBEB89BF0VE1PR04MB6638eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: db82b458-7f95-496d-ad76-08d7f755111b
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 15:48:22.5313
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tPscbgD7Sai+Gzc2L0g/wIjb1th/Eve8EkAFzzIRINg6IgJ+suSsTj8lrZsJfKIy1LKnyKCQ3a+OCLTkvtmlqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6654
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--_002_VE1PR04MB663876FA31A281A388F2BBEB89BF0VE1PR04MB6638eurp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On 2020/05/13 Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, May 13, 2020 at 08:52:39AM +0000, Robin Gong wrote:
> > On 2020/05/13 16:48 Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > > On Wed, May 13, 2020 at 08:38:26AM +0000, Robin Gong wrote:
> > > > On 2020/05/13 Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > > > > This patch is the one bisecting will end up with when somebody
> > > > > uses an older SDMA firmware or the ROM scripts. It should have a
> > > > > better description what happens and what should be done about it.
> > > > Emm..That's true. Timeout will be caught in such case, hence,
> > > > maybe we can
> > > fall back it to pio always.
> > >
> > > With my patch applied sdma_load_context() will fail. I don't know
> > > how exactly this hits into the SPI driver, but it won't be a timeout.
> > Thanks for your quick test, assume you use ROM firmware, right?
>=20
> Yes.
Would you please have a try with the attached patch which is based this pat=
ch set?

--_002_VE1PR04MB663876FA31A281A388F2BBEB89BF0VE1PR04MB6638eurp_
Content-Type: application/octet-stream;
	name="0014-spi-imx-fallback-to-PIO-if-dma-setup-failure.patch"
Content-Description: 0014-spi-imx-fallback-to-PIO-if-dma-setup-failure.patch
Content-Disposition: attachment;
	filename="0014-spi-imx-fallback-to-PIO-if-dma-setup-failure.patch";
	size=3274; creation-date="Wed, 13 May 2020 15:46:25 GMT";
	modification-date="Wed, 13 May 2020 15:46:25 GMT"
Content-Transfer-Encoding: base64

RnJvbSBiNGY5ODYwYmU4Y2M4Yjk2NzI2MjZiYWE2MmE0Y2VjODljZjI5ZTg3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JpbiBHb25nIDx5aWJpbi5nb25nQG54cC5jb20+CkRhdGU6
IFRodSwgMTQgTWF5IDIwMjAgMDc6MTg6MzMgKzA4MDAKU3ViamVjdDogW1BBVENIIHY3IFJFU0VO
RCAxNC8xNF0gc3BpOiBpbXg6IGZhbGxiYWNrIHRvIFBJTyBpZiBkbWEgc2V0dXAKIGZhaWx1cmUK
CkZhbGxiYWNrIHRvIFBJTyBpbiBjYXNlIGRtYSBzZXR1cCBmYWlsZWQuIEZvciBleGFtcGxlLCBz
ZG1hIGZpcm13YXJlIG5vdAp1cGRhdGVkIGJ1dCBFUlIwMDkxNjUgd29ya2Fyb3VkIGFkZGVkIGlu
IGtlcm5lbC4KClNpZ25lZC1vZmYtYnk6IFJvYmluIEdvbmcgPHlpYmluLmdvbmdAbnhwLmNvbT4K
LS0tCiBkcml2ZXJzL3NwaS9zcGktaW14LmMgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysr
KystLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9kcml2ZXJzL3NwaS9zcGktaW14LmMgYi9kcml2ZXJzL3NwaS9zcGktaW14
LmMKaW5kZXggYTU3ZWRjYi4uNTY1MDVjYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9zcGkvc3BpLWlt
eC5jCisrKyBiL2RyaXZlcnMvc3BpL3NwaS1pbXguYwpAQCAtNzIsNiArNzIsNyBAQCBzdHJ1Y3Qg
c3BpX2lteF9kZXZ0eXBlX2RhdGEgewogCXZvaWQgKCpyZXNldCkoc3RydWN0IHNwaV9pbXhfZGF0
YSAqKTsKIAl2b2lkICgqc2V0dXBfd21sKShzdHJ1Y3Qgc3BpX2lteF9kYXRhICopOwogCXZvaWQg
KCpkaXNhYmxlKShzdHJ1Y3Qgc3BpX2lteF9kYXRhICopOworCXZvaWQgKCpkaXNhYmxlX2RtYSko
c3RydWN0IHNwaV9pbXhfZGF0YSAqKTsKIAlib29sIGhhc19kbWFtb2RlOwogCWJvb2wgaGFzX3Ns
YXZlbW9kZTsKIAl1bnNpZ25lZCBpbnQgZmlmb19zaXplOwpAQCAtNDk2LDYgKzQ5NywxMSBAQCBz
dGF0aWMgdm9pZCBteDUxX2Vjc3BpX3RyaWdnZXIoc3RydWN0IHNwaV9pbXhfZGF0YSAqc3BpX2lt
eCkKIAl3cml0ZWwocmVnLCBzcGlfaW14LT5iYXNlICsgTVg1MV9FQ1NQSV9DVFJMKTsKIH0KIAor
c3RhdGljIHZvaWQgbXg1MV9kaXNhYmxlX2RtYShzdHJ1Y3Qgc3BpX2lteF9kYXRhICpzcGlfaW14
KQoreworCXdyaXRlbCgwLCBzcGlfaW14LT5iYXNlICsgTVg1MV9FQ1NQSV9ETUEpOworfQorCiBz
dGF0aWMgdm9pZCBteDUxX2Vjc3BpX2Rpc2FibGUoc3RydWN0IHNwaV9pbXhfZGF0YSAqc3BpX2lt
eCkKIHsKIAl1MzIgY3RybDsKQEAgLTEwMDgsNiArMTAxNCw3IEBAIHN0YXRpYyBzdHJ1Y3Qgc3Bp
X2lteF9kZXZ0eXBlX2RhdGEgaW14NTFfZWNzcGlfZGV2dHlwZV9kYXRhID0gewogCS5yeF9hdmFp
bGFibGUgPSBteDUxX2Vjc3BpX3J4X2F2YWlsYWJsZSwKIAkucmVzZXQgPSBteDUxX2Vjc3BpX3Jl
c2V0LAogCS5zZXR1cF93bWwgPSBteDUxX3NldHVwX3dtbCwKKwkuZGlzYWJsZV9kbWEgPSBteDUx
X2Rpc2FibGVfZG1hLAogCS5maWZvX3NpemUgPSA2NCwKIAkuaGFzX2RtYW1vZGUgPSB0cnVlLAog
CS5keW5hbWljX2J1cnN0ID0gdHJ1ZSwKQEAgLTEwMjIsNiArMTAyOSw3IEBAIHN0YXRpYyBzdHJ1
Y3Qgc3BpX2lteF9kZXZ0eXBlX2RhdGEgaW14NTNfZWNzcGlfZGV2dHlwZV9kYXRhID0gewogCS5w
cmVwYXJlX3RyYW5zZmVyID0gbXg1MV9lY3NwaV9wcmVwYXJlX3RyYW5zZmVyLAogCS50cmlnZ2Vy
ID0gbXg1MV9lY3NwaV90cmlnZ2VyLAogCS5yeF9hdmFpbGFibGUgPSBteDUxX2Vjc3BpX3J4X2F2
YWlsYWJsZSwKKwkuZGlzYWJsZV9kbWEgPSBteDUxX2Rpc2FibGVfZG1hLAogCS5yZXNldCA9IG14
NTFfZWNzcGlfcmVzZXQsCiAJLmZpZm9fc2l6ZSA9IDY0LAogCS5oYXNfZG1hbW9kZSA9IHRydWUs
CkBAIC0xNDMwLDYgKzE0MzgsNyBAQCBzdGF0aWMgaW50IHNwaV9pbXhfZG1hX3RyYW5zZmVyKHN0
cnVjdCBzcGlfaW14X2RhdGEgKnNwaV9pbXgsCiAJCQkJRE1BX1BSRVBfSU5URVJSVVBUIHwgRE1B
X0NUUkxfQUNLKTsKIAlpZiAoIWRlc2NfdHgpIHsKIAkJZG1hZW5naW5lX3Rlcm1pbmF0ZV9hbGwo
bWFzdGVyLT5kbWFfdHgpOworCQlkbWFlbmdpbmVfdGVybWluYXRlX2FsbChtYXN0ZXItPmRtYV9y
eCk7CiAJCXJldHVybiAtRUlOVkFMOwogCX0KIApAQCAtMTU0Myw2ICsxNTUyLDcgQEAgc3RhdGlj
IGludCBzcGlfaW14X3RyYW5zZmVyKHN0cnVjdCBzcGlfZGV2aWNlICpzcGksCiAJCQkJc3RydWN0
IHNwaV90cmFuc2ZlciAqdHJhbnNmZXIpCiB7CiAJc3RydWN0IHNwaV9pbXhfZGF0YSAqc3BpX2lt
eCA9IHNwaV9tYXN0ZXJfZ2V0X2RldmRhdGEoc3BpLT5tYXN0ZXIpOworCWludCByZXQ7CiAKIAkv
KiBmbHVzaCByeGZpZm8gYmVmb3JlIHRyYW5zZmVyICovCiAJd2hpbGUgKHNwaV9pbXgtPmRldnR5
cGVfZGF0YS0+cnhfYXZhaWxhYmxlKHNwaV9pbXgpKQpAQCAtMTU1MSwxMCArMTU2MSwyMyBAQCBz
dGF0aWMgaW50IHNwaV9pbXhfdHJhbnNmZXIoc3RydWN0IHNwaV9kZXZpY2UgKnNwaSwKIAlpZiAo
c3BpX2lteC0+c2xhdmVfbW9kZSkKIAkJcmV0dXJuIHNwaV9pbXhfcGlvX3RyYW5zZmVyX3NsYXZl
KHNwaSwgdHJhbnNmZXIpOwogCi0JaWYgKHNwaV9pbXgtPnVzZWRtYSkKLQkJcmV0dXJuIHNwaV9p
bXhfZG1hX3RyYW5zZmVyKHNwaV9pbXgsIHRyYW5zZmVyKTsKLQllbHNlCi0JCXJldHVybiBzcGlf
aW14X3Bpb190cmFuc2ZlcihzcGksIHRyYW5zZmVyKTsKKwkvKgorCSAqIGZhbGxiYWNrIFBJTyBt
b2RlIGlmIGRtYSBzZXR1cCBlcnJvciBoYXBwZW4sIGZvciBleGFtcGxlIHNkbWEKKwkgKiBmaXJt
d2FyZSBtYXkgbm90IGJlIHVwZGF0ZWQgYXMgRVJSMDA5MTY1IHJlcXVpcmVkLgorCSAqLworCWlm
IChzcGlfaW14LT51c2VkbWEpIHsKKwkJcmV0ID0gc3BpX2lteF9kbWFfdHJhbnNmZXIoc3BpX2lt
eCwgdHJhbnNmZXIpOworCQlpZiAocmV0ICE9IC1FSU5WQUwpCisJCQlyZXR1cm4gcmV0OworCisJ
CXNwaV9pbXgtPmRldnR5cGVfZGF0YS0+ZGlzYWJsZV9kbWEoc3BpX2lteCk7CisKKwkJc3BpX2lt
eC0+dXNlZG1hID0gZmFsc2U7CisJCXNwaV9pbXgtPmR5bmFtaWNfYnVyc3QgPSBzcGlfaW14LT5k
ZXZ0eXBlX2RhdGEtPmR5bmFtaWNfYnVyc3Q7CisJCWRldl9pbmZvKCZzcGktPmRldiwgIkZhbGxi
YWNrIHRvIFBJTyBtb2RlXG4iKTsKKwl9CisKKwlyZXR1cm4gc3BpX2lteF9waW9fdHJhbnNmZXIo
c3BpLCB0cmFuc2Zlcik7CiB9CiAKIHN0YXRpYyBpbnQgc3BpX2lteF9zZXR1cChzdHJ1Y3Qgc3Bp
X2RldmljZSAqc3BpKQotLSAKMi43LjQKCg==

--_002_VE1PR04MB663876FA31A281A388F2BBEB89BF0VE1PR04MB6638eurp_--