Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200513154718.17401-1-michael.srba@seznam.cz>
In-Reply-To: <20200513154718.17401-1-michael.srba@seznam.cz>
From:   Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Date:   Wed, 13 May 2020 10:04:30 -0600
Message-ID: <CAOCk7No3bJMpZNjXaNv-OScaLXPKbdj3d_n20ss3MyciPO=e3g@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices
 with broken coresight
To:     michael.srba@seznam.cz
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        MSM <linux-arm-msm@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 13, 2020 at 9:53 AM <michael.srba@seznam.cz> wrote:
>
> From: Michael Srba <michael.srba@seznam.cz>
>
> Attempting to enable these devices causes a "synchronous
> external abort". Suspected cause is that the debug power
> domain is not enabled by default on this device.
> Disable these devices for now to avoid the crash.
>
> See: https://lore.kernel.org/linux-arm-msm/20190618202623.GA53651@gerhold.net/
>
> Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
> Signed-off-by: Michael Srba <michael.srba@seznam.cz>
>
> ---
>  arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts       | 6 ++++++
>  arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
>  2 files changed, 12 insertions(+)

Why are we disabling these in board specific files?  Seems like these
should be disabled in the base msm8916.dtsi.  Otherwise, the next
board that gets brought up is probably going to hit this same exact
issue.

This also follows the solution that msm8998 did for the same issue.